-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Platform.io Adapter #2230
Conversation
## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params
## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params
Update platformioBidAdapter
Endpoint URL change
Endpoint URL change
Hi @varashellov , I reviewed the changes and they seem fine to me. However, I was trying to test out your adapter with this new code using the test param information from the Platform.io Bid Adapter document and I had some trouble with both the native and the banner ad units. In the case of the native, I was successfully receiving a bid response but it seemed to have trouble rendering the ad on the hello_world test page. I was emulating the page using Chrome's inspector tool, and consistently saw the In the case of the banner, I wasn't receiving a bid response from your system. While the request was executed, it always completed with status code 204 and there was no response data at all. (note - when I tested with the native, the request completed as a 200). Could you take a look into this behavior and verify on your end if the test deliveries are working or if the test information need to be updated? Thanks! |
Hi @jsnellbaker ,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 'master' of https://github.com/prebid/Prebid.js: (76 commits) Updated adUnitCode (prebid#2262) vastUrl is set based on nurl for video. (prebid#2249) Added ad id to a4g bid (prebid#2250) Add billing url (burl) support (prebid#2246) Fix: add mediatype in bid response (prebid#2260) use b64EncodeUnicode to encode strings with unicode chars in them (prebid#2245) create RELEASE_SCHEDULE.md (prebid#2255) Update Platform.io Adapter (prebid#2230) Update Lifestreet adapter to 1.0 (prebid#2197) PBS adapter not sending app or device (prebid#2206) Fix prebid#2229 - Edge cookie string form (prebid#2236) Add Invibes Adapter (prebid#2202) Increment pre version Prebid 1.5.0 Release Fix cross-platform test failures (prebid#2228) Fix uncahced video bids from multi-response array triggering callback early (prebid#2219) Add vuble adapter (prebid#2201) Update Vidazoo domain (prebid#2223) InSkin Bid Adapter: remove referrer field from request body (prebid#2217) Gamma Support UserSync Endpoint (prebid#2216) ...
* master: Audience Network: Add 'pbv' and 'cb' query params (prebid#2252) Add e-planning analytics adapter (prebid#2211) Add vastUrl for Gamma Adapter Video (prebid#2261) update params for test bid (prebid#2267) Updated adUnitCode (prebid#2262) vastUrl is set based on nurl for video. (prebid#2249) Added ad id to a4g bid (prebid#2250) Add billing url (burl) support (prebid#2246) Fix: add mediatype in bid response (prebid#2260) use b64EncodeUnicode to encode strings with unicode chars in them (prebid#2245) create RELEASE_SCHEDULE.md (prebid#2255) Update Platform.io Adapter (prebid#2230) Update Lifestreet adapter to 1.0 (prebid#2197) PBS adapter not sending app or device (prebid#2206) Fix prebid#2229 - Edge cookie string form (prebid#2236) Add Invibes Adapter (prebid#2202)
* Add PlatformioBidAdapter * Update platformioBidAdapter.js * Add files via upload * Update hello_world.html * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Update hello_world.html * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update hello_world.html * Add files via upload * Update platformioBidAdapter ## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params * Update platformioBidAdapter * Update platformioBidAdapter ## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.js Endpoint URL change * Update platformioBidAdapter_spec.js Endpoint URL change * Update platformioBidAdapter_spec.js * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update platformioBidAdapter.md
Type of change
Description of change
'banner' is added to supportedMediaTypes
image and icon sizes are added for native bid
siarhei.kasukhin@platform.io
Other information