Add vastUrl for Gamma Adapter Video #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed mediaType in bid and return vastXml property if video request
jsnellbaker
reviewed
Mar 14, 2018
There was a problem hiding this comment.
Hi @gammassp ,
Overall these changes look good me. I was able to test out the new userSync code you added and saw the request fired off to your endpoint.
I was wondering though if you had a test placement that returned video to check/verify the new vastUrl property you added. I tried the test params in the PR but I was consistently seeing a banner return.
Please let me know when you have the chance.
matthewlane
requested changes
Mar 14, 2018
There was a problem hiding this comment.
The Gamma bidder spec should add
supportedMediaTypes: ['banner', 'video'],(below aliases or anywhere in the spec is fine) since it supports both banner and video formats. See this note in the docs for more info
|
Hi, The supportedMediaTypes added to bidder specs and I have just added test parameters for video
Please check again |
jsnellbaker
approved these changes
Mar 15, 2018
There was a problem hiding this comment.
Thanks @gammassp for making these changes. I tested out the new test params on an instream video test page and it seemed to be working fine.
matthewlane
approved these changes
Mar 15, 2018
mizmaar3
added a commit
to widespace-os/Prebid.js
that referenced
this pull request
Mar 19, 2018
* master: Audience Network: Add 'pbv' and 'cb' query params (prebid#2252) Add e-planning analytics adapter (prebid#2211) Add vastUrl for Gamma Adapter Video (prebid#2261) update params for test bid (prebid#2267) Updated adUnitCode (prebid#2262) vastUrl is set based on nurl for video. (prebid#2249) Added ad id to a4g bid (prebid#2250) Add billing url (burl) support (prebid#2246) Fix: add mediatype in bid response (prebid#2260) use b64EncodeUnicode to encode strings with unicode chars in them (prebid#2245) create RELEASE_SCHEDULE.md (prebid#2255) Update Platform.io Adapter (prebid#2230) Update Lifestreet adapter to 1.0 (prebid#2197) PBS adapter not sending app or device (prebid#2206) Fix prebid#2229 - Edge cookie string form (prebid#2236) Add Invibes Adapter (prebid#2202)
mifefr
added a commit
to mifefr/Prebid.js
that referenced
this pull request
Mar 29, 2018
* 'master' of https://github.com/prebid/Prebid.js: EngageBDR New Bid Adapter (prebid#2309) [FEAT] adunit sizes support (prebid#2320) Support aliases in prebidServer (prebid#2257) Changing default currency file to https (prebid#2306) Update stalebot labels (prebid#2319) Enhance location detection within utils (prebid#2167) if cache markup is not enabled, set it to the default value 0 (prebid#2302) Serverbid Bid Adapter: Added archon alias (prebid#2293) Smart Ad Server: Fix bug when multi bids (prebid#2170) NEW adapter AdtelligentBidAdapter (prebid#2137) add optional param to bridgewellBidAdapter (prebid#2289) Increment Pre Version Prebid 1.6.0 Release Unit test fixes (prebid#2301) PBS videoCacheKey and vastUrl (prebid#2101) Add Oneplanetonly Bid Adapter (prebid#2269) firing new adRenderFailed event when renderAd() fails (prebid#2210) Add Content Ignite adapter (prebid#2268) add hb_cache_id, hb_uuid should be deprecated and replaced by hb_cache_id (prebid#2273) Update Yieldlab adapter and add official maintainer (prebid#2231) Update for Media.net adapter (prebid#2232) Update to Rubicon Adapter for mediaTypes support (prebid#2272) message formatting (prebid#2285) Yieldbot impression image creation fix (prebid#2277) Updated Bid params (prebid#2275) Audience Network: Add 'pbv' and 'cb' query params (prebid#2252) Add e-planning analytics adapter (prebid#2211) Add vastUrl for Gamma Adapter Video (prebid#2261) update params for test bid (prebid#2267) Updated adUnitCode (prebid#2262)
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* commit gamma adapter * Fixed The Travis CI build failed * fix interpretResponse return empty when server response empty * removed mediaType removed mediaType in bid and return vastXml property if video request * fixed Travis CI build * Travis CI build * add gamma spec * fixed Travis CI build * fix spec * fix spec * Add files via upload * Add files via upload * fix spec * fix Travis CI build * move to module * remove gaxDomain param and move to adapter * remove check isBidRequestValid for gaxDomain * remove gaxDomain param * remove gaxDomain param * remove gaxDomain param * Delete gammaBidAdapter_spec.js * add usersync endpoid * add usersync * add vastUrl * add supportedMediaTypes to bidder spec * add Test Parameters: For Video
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Support vastUrl for Video