PBS videoCacheKey and vastUrl #2101
Conversation
|
I'm not convinced we fully understand this problem. There's a broader issue where setting s2sConfig.cacheMarkup=1 destroys display ads. Yet it's required for video which is on the same page. Going to assign it to back to @moonshells who will report on our internal discussions. |
|
is this ready for review? |
…dy cached video bids only
|
@mkendall07 Yes, please review it. |
modules/prebidServerBidAdapter.js
Outdated
| bidObject.videoCacheKey = bidObj.cache_id; | ||
| } | ||
| if (bidObj.cache_url) { | ||
| bidObject.vastUrl = bidObj.cache_url; |
There was a problem hiding this comment.
I don't think this does anything by itself? ie, prebid.js will still try to cache this URL, so essentially your double caching here I believe. You'd need a way to signal to the core prebid library not to cache this bid.
There was a problem hiding this comment.
upon further review: it does check:
https://github.com/prebid/Prebid.js/blob/master/src/auction.js#L230
There was a problem hiding this comment.
Do note that the current version of AMP support does not include cache_url, it only sends the cache_id.
There was a problem hiding this comment.
if that is the case, we need to update this to check both keys exist. Otherwise we'll break caching if cache_url doesn't exist.
|
@mkendall07 Thanks for pointing this out! Bug fixed. |
Type of change
Description of change
When video bids are cached by Prebid Server (Rubicon Video is using server side cache), there's no need to cache them in Prebid.js, they should have correct videoCacheKey and vastUrl.