Update for Media.net adapter #2232
Conversation
modules/medianetBidAdapter.js
Outdated
|
|
||
| let bidParams = {}; | ||
|
|
||
| events.on(BID_TIMEOUT, function (timedOutBidders) { |
There was a problem hiding this comment.
Listening to and logging event data isn't allowed in a bidder adapter, but is in an analytics adapter.
There was a problem hiding this comment.
Hey @matthewlane ,
Shouldn't the bidder timeout be allowed in the main adapter, the analytics adapter could listen to a lot more events based on the environment. The publisher might not always pick the analytics adapter, as it generally leads to more px calls on the browser.
However the client timeout is an important event that the bidder must listen to to optimize, tweak things at its end. This optimization could directly lead to better yields to the publisher.
Your views?
Thanks,
Ruturaj
There was a problem hiding this comment.
Makes sense. The BID_TIMEOUT event still shouldn't be listened to in bidder adapters as it may contain data from other bidders, even though you are filtering them out below, but I've create an issue to define and implement a way for bidders to subscribe to their own timed out event data: #2254. Feel free to comment on that or use it for tracking and whenever a PR is merged you'll be able to use it here
|
@matthewlane , We have removed timeout event binding, can you please check and merge ? |
|
|
||
| const BIDDER_CODE = 'medianet'; | ||
| const BID_URL = 'https://prebid.media.net/rtb/prebid'; | ||
|
|
||
| $$PREBID_GLOBAL$$.medianetGlobals = {}; |
There was a problem hiding this comment.
This is ok since no public api functions are being invoked but we encourage adapters to use $$PREBID_GLOBAL$$ as little as possible. localStorage might suit this use case without needing to use the pbjs global
Type of change
Description of change
This PR adds the following :
tmax,prebid_versionandall