Update Yieldlab adapter and add official maintainer #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yieldlab auctions are valid for 5 minutes and not 10. A delivery of an adtag would lead to a new auction after the 5 minute expiration time.
Did stands for demandId which is not a default and not a good identifer for deals. We should use pid (partnershipId) here as a unique identifer for a connection between supply and demand (including deals).
The adsize of a video placement can have a lot of different adsizes and is never "1x1".
Platform Lunar and Yieldlab agree that the Adapter should be offically maintained by Yieldlab.
Campaigns set up in Yieldlab's test network to deliver all the time.
To make it less confusing for customers, we should use the actual naming used in our systems for the params used.
harpere
reviewed
Mar 16, 2018
| @@ -67,16 +67,16 @@ export const spec = { | |||
| width: sizes[0], | |||
| height: sizes[1], | |||
| creativeId: '' + matchedBid.id, | |||
| dealId: matchedBid.did, | |||
| dealId: matchedBid.pid, | |||
There was a problem hiding this comment.
May want to add a test that verifies pid is being mapped to dealId as you expect. Would also help verify that this was an intended change!
There was a problem hiding this comment.
Thank you for your comment. I agree and added a commit: 4010d70
There was a problem hiding this comment.
looks good, thx. will get this merged.
harpere
approved these changes
Mar 19, 2018
mifefr
added a commit
to mifefr/Prebid.js
that referenced
this pull request
Mar 29, 2018
* 'master' of https://github.com/prebid/Prebid.js: EngageBDR New Bid Adapter (prebid#2309) [FEAT] adunit sizes support (prebid#2320) Support aliases in prebidServer (prebid#2257) Changing default currency file to https (prebid#2306) Update stalebot labels (prebid#2319) Enhance location detection within utils (prebid#2167) if cache markup is not enabled, set it to the default value 0 (prebid#2302) Serverbid Bid Adapter: Added archon alias (prebid#2293) Smart Ad Server: Fix bug when multi bids (prebid#2170) NEW adapter AdtelligentBidAdapter (prebid#2137) add optional param to bridgewellBidAdapter (prebid#2289) Increment Pre Version Prebid 1.6.0 Release Unit test fixes (prebid#2301) PBS videoCacheKey and vastUrl (prebid#2101) Add Oneplanetonly Bid Adapter (prebid#2269) firing new adRenderFailed event when renderAd() fails (prebid#2210) Add Content Ignite adapter (prebid#2268) add hb_cache_id, hb_uuid should be deprecated and replaced by hb_cache_id (prebid#2273) Update Yieldlab adapter and add official maintainer (prebid#2231) Update for Media.net adapter (prebid#2232) Update to Rubicon Adapter for mediaTypes support (prebid#2272) message formatting (prebid#2285) Yieldbot impression image creation fix (prebid#2277) Updated Bid params (prebid#2275) Audience Network: Add 'pbv' and 'cb' query params (prebid#2252) Add e-planning analytics adapter (prebid#2211) Add vastUrl for Gamma Adapter Video (prebid#2261) update params for test bid (prebid#2267) Updated adUnitCode (prebid#2262)
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Set time to live to 5 minutes Yieldlab auctions are valid for 5 minutes and not 10. A delivery of an adtag would lead to a new auction after the 5 minute expiration time. * Use correct identifer for deals Did stands for demandId which is not a default and not a good identifer for deals. We should use pid (partnershipId) here as a unique identifer for a connection between supply and demand (including deals). * Set revenue to gross-price * Add dynamic adsize for vast url The adsize of a video placement can have a lot of different adsizes and is never "1x1". * Change maintainer to Yieldlab Platform Lunar and Yieldlab agree that the Adapter should be offically maintained by Yieldlab. * Use yieldlab test campaigns Campaigns set up in Yieldlab's test network to deliver all the time. * Use yieldlab naming for params To make it less confusing for customers, we should use the actual naming used in our systems for the params used. * Update test spec for yieldlab adapter * Add test for pid to dealId mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Official update from Yieldlab. Many thanks to our friends from Platform Lunar for the work on the adapter.
Bugfixes:
Other:
Changed params to the actual naming used by Yieldlab to avoid confusion from customers. Corresponding Pull Request to the documentation: Update Yieldlab params with new naming prebid.github.io#651
Updated maintainer to be Yieldlab
contact email of the adapter’s maintainer: solutions@yieldlab.de
official adapter submission