Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yieldlab adapter and add official maintainer #2231

Merged
merged 9 commits into from
Mar 19, 2018
Merged

Update Yieldlab adapter and add official maintainer #2231

merged 9 commits into from
Mar 19, 2018

Commits on Mar 2, 2018

  1. Set time to live to 5 minutes

    Yieldlab auctions are valid for 5 minutes and not 10. A delivery of an adtag would lead to a new auction after the 5 minute expiration time.
    mirkorean committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    aed8f4f View commit details
    Browse the repository at this point in the history
  2. Use correct identifer for deals

    Did stands for demandId which is not a default and not a good identifer for deals. We should use pid (partnershipId) here as a unique identifer for a connection between supply and demand (including deals).
    mirkorean committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    85fef2a View commit details
    Browse the repository at this point in the history
  3. Set revenue to gross-price

    mirkorean committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    05ffa4b View commit details
    Browse the repository at this point in the history
  4. Add dynamic adsize for vast url

    The adsize of a video placement can have a lot of different adsizes and is never "1x1".
    mirkorean committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    c332432 View commit details
    Browse the repository at this point in the history
  5. Change maintainer to Yieldlab

    Platform Lunar and Yieldlab agree that the Adapter should be offically maintained by Yieldlab.
    mirkorean committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    78186b8 View commit details
    Browse the repository at this point in the history
  6. Use yieldlab test campaigns

    Campaigns set up in Yieldlab's test network to deliver all the time.
    mirkorean committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    052041c View commit details
    Browse the repository at this point in the history
  7. Use yieldlab naming for params

    To make it less confusing for customers, we should use the actual naming used in our systems for the params used.
    mirkorean committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    fa4d49f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    146ac1c View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2018

  1. Configuration menu
    Copy the full SHA
    4010d70 View commit details
    Browse the repository at this point in the history