-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Yieldlab adapter and add official maintainer #2231
Merged
Merged
Commits on Mar 2, 2018
-
Yieldlab auctions are valid for 5 minutes and not 10. A delivery of an adtag would lead to a new auction after the 5 minute expiration time.
Configuration menu - View commit details
-
Copy full SHA for aed8f4f - Browse repository at this point
Copy the full SHA aed8f4fView commit details -
Use correct identifer for deals
Did stands for demandId which is not a default and not a good identifer for deals. We should use pid (partnershipId) here as a unique identifer for a connection between supply and demand (including deals).
Configuration menu - View commit details
-
Copy full SHA for 85fef2a - Browse repository at this point
Copy the full SHA 85fef2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05ffa4b - Browse repository at this point
Copy the full SHA 05ffa4bView commit details -
Add dynamic adsize for vast url
The adsize of a video placement can have a lot of different adsizes and is never "1x1".
Configuration menu - View commit details
-
Copy full SHA for c332432 - Browse repository at this point
Copy the full SHA c332432View commit details -
Platform Lunar and Yieldlab agree that the Adapter should be offically maintained by Yieldlab.
Configuration menu - View commit details
-
Copy full SHA for 78186b8 - Browse repository at this point
Copy the full SHA 78186b8View commit details -
Campaigns set up in Yieldlab's test network to deliver all the time.
Configuration menu - View commit details
-
Copy full SHA for 052041c - Browse repository at this point
Copy the full SHA 052041cView commit details -
Use yieldlab naming for params
To make it less confusing for customers, we should use the actual naming used in our systems for the params used.
Configuration menu - View commit details
-
Copy full SHA for fa4d49f - Browse repository at this point
Copy the full SHA fa4d49fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 146ac1c - Browse repository at this point
Copy the full SHA 146ac1cView commit details
Commits on Mar 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 4010d70 - Browse repository at this point
Copy the full SHA 4010d70View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.