Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadPeak adapter #2369

Merged
merged 4 commits into from
Apr 27, 2018
Merged

Update ReadPeak adapter #2369

merged 4 commits into from
Apr 27, 2018

Conversation

kurrestahlberg
Copy link
Contributor

Type of change

  • Bugfix
  • Refactoring (no functional changes, no api changes)

Description of change

Updates to the ReadPeak adapter to match changes to the ReadPeak system as well as some minor refactoring to clean up the adapter and make it a better citizen in Prebid.

return undefined;
}

function referrer() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates the utils function getTopWindowReferrer(). Please use that function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed that function. Fixed.

@mike-chowla
Copy link
Contributor

When I went to test these changes using the test params from the original adapter submission, I'm getting back 400 Bad Request request error

@kurrestahlberg
Copy link
Contributor Author

I'm not sure what's going on. I see your tests in the log but they have the old format request. The old adapter code stopped working once we moved to tighter openrtb compliance in the back end.

@kurrestahlberg
Copy link
Contributor Author

I don't mean to spam, but what is the status of this PR?

The problem above @mike-chowla saw is most likely a caching issue or accidentally not having the latest code as the format of the request was different from what this PR has and the change requested was made.

@mike-chowla mike-chowla merged commit fae4048 into prebid:master Apr 27, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Update ReadPeak adapter

* Replace $$PREBID_GLOBAL$$.version with $prebid.version$

* Fix test

* Use utils.getTopWindowReferrer() instead of custom function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants