Update ReadPeak adapter (legacy) #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kurrestahlberg - please look into the travis-ci issue |
|
@bretg looks like it resolved itself. the best kind of an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the same PR as #2369 but for legacy branch and with one extra fix for tests. It seems that
config.getConfig('publisherDomain')returns different value in legacy and master.Type of change
Description of change
Updates to the ReadPeak adapter to match changes to the ReadPeak system as well as some minor refactoring to clean up the adapter and make it a better citizen in Prebid.
kurre.stahlberg@readpeak.com