consentManagement - add support for safeframe workflow #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
reviewed
May 11, 2018
| function callCmpWhileInSafeFrame() { | ||
| function sfCallback(msgName, data) { | ||
| if (msgName === 'cmpReturn') { | ||
| cmpSuccess(data.vendorConsents); |
There was a problem hiding this comment.
The spec uses data.VendorConsents (with a capital V). Not sure if it's a typo, or may be referring to the full VendorConsents object. should confirm this.
There was a problem hiding this comment.
I checked internally with our resident CMP developer and he indicated it should be lower-case (ie normal syntax).
harpere
added
needs 2nd review
mkendall07
approved these changes
May 15, 2018
| * @param {object} adUnit one adUnit object from the normal list of adUnits | ||
| * @returns {array[array[number]]} array of arrays containing numeric sizes | ||
| */ | ||
| export function getAdUnitSizes(adUnit) { |
There was a problem hiding this comment.
any reason this is a new function vs reusing parseSizesInput ?
There was a problem hiding this comment.
that function converts the sizes into an array of strings like ["300x250"]. I just wanted the actual sizes to reassign into the register call and not have to parse it again.
ArmandChoy
pushed a commit
to RockYou-Ads/Prebid.js
that referenced
this pull request
May 15, 2018
* PreBid.js/master: (79 commits) increment prebid version Prebid 1.11.0 release replace find reference with imported version (prebid#2542) GDPR - add consent information to PBS cookie_sync request (prebid#2530) add support for safeframe workflow and new utils method to read adunit sizes (prebid#2523) Smart: GDPR support (prebid#2528) fix getPreparedBidForAuction to look for renderer on correct bid (prebid#2505) PubMatic Adapter: Bug fix to read all bids from seatBid array (prebid#2520) Create GXOne Bid Adapter and tests for it (prebid#2540) Lifestreet: gdpr and consent string parameters (prebid#2537) -GDPR support added in media net bidder (prebid#2538) change AppNexus endpoint to use ORTB (prebid#2532) fixed bug when latitute/longitue are not provided (prebid#2533) added gdpr support to userSync in rubicon adapter (prebid#2531) Show only summary and errors (prebid#2514) Aardvark v1.0 (prebid#2507) Add 1024x768 (size_id = 53) in sizeMap (prebid#2527) Add new Adapter brainyBidAdapter (prebid#2458) OpenX Adapter: GDPR Support (prebid#2504) add support for latLong in rubicon adapter (prebid#2508) ...
1 task
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR adds support for the safeframe workflow that's described in the 1.1 CMP spec for the consentManagement module.
See link here for details from the spec.
Also added new method in utils to read the
adUnitsobject to grab the sizes from eitheradUnit.mediaTypes.banner.sizesoradUnit.sizes. We use the firstadUnitsobject's dimensions as part of the safeframe register function.