Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart: GDPR support #2528

Merged
merged 5 commits into from
May 15, 2018
Merged

Smart: GDPR support #2528

merged 5 commits into from
May 15, 2018

Conversation

ytyukhnin
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Adding GDPR support to Smart's prebid adapter.

Please use the following test parameters:

          {
            code: 'div-gpt-ad-1460505748561-0',
            sizes: [[300, 250]],  // a display size
            bids: [{
              bidder: "smart",
              params: {
                domain: 'http://ww251.smartadserver.com',
                siteId: 207435,
                pageId: 896536,
                formatId: 62913
              }
            }]
          }

As a result Smart's adapter should send acquired GDPR params in the POST message.

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkendall07
Copy link
Member

@ytyukhnin
please open a PR for the docs to your adapter with gdpr_supported: true.

See here as an example prebid/prebid.github.io@1522adf

@ytyukhnin
Copy link
Contributor Author

Hi @mkendall07,

Thank you. It's already done:
prebid/prebid.github.io#759

@mkendall07 mkendall07 merged commit b746bf1 into prebid:master May 15, 2018
ArmandChoy pushed a commit to RockYou-Ads/Prebid.js that referenced this pull request May 15, 2018
* PreBid.js/master: (79 commits)
  increment prebid version
  Prebid 1.11.0 release
  replace find reference with imported version (prebid#2542)
  GDPR - add consent information to PBS cookie_sync request (prebid#2530)
  add support for safeframe workflow and new utils method to read adunit sizes (prebid#2523)
  Smart: GDPR support (prebid#2528)
  fix getPreparedBidForAuction to look for renderer on correct bid (prebid#2505)
  PubMatic Adapter: Bug fix to read all bids from seatBid array (prebid#2520)
  Create GXOne Bid Adapter and tests for it (prebid#2540)
  Lifestreet: gdpr and consent string parameters (prebid#2537)
  -GDPR support added in media net bidder (prebid#2538)
  change AppNexus endpoint to use ORTB (prebid#2532)
  fixed bug when latitute/longitue are not provided (prebid#2533)
  added gdpr support to userSync in rubicon adapter (prebid#2531)
  Show only summary and errors (prebid#2514)
  Aardvark v1.0 (prebid#2507)
  Add 1024x768 (size_id = 53) in sizeMap (prebid#2527)
  Add new Adapter brainyBidAdapter (prebid#2458)
  OpenX Adapter: GDPR Support (prebid#2504)
  add support for latLong in rubicon adapter (prebid#2508)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants