update conversant bid adapter to use video playerSize instead of sizes #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to determine the video player size
bretg
approved these changes
Dec 13, 2018
10 tasks
loic-talon
pushed a commit
to onfocusio/Prebid.js
that referenced
this pull request
Dec 19, 2018
…s to determine the video player size (prebid#3372)
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…s to determine the video player size (prebid#3372)
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
…s to determine the video player size (prebid#3372)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updates conversant bid adapter to use mediaTypes.video.playerSize to determine the size of the video, instead of using sizes if the playerSize is given. If playerSize is not given, it will default to using sizes in order to not change current behavior.
Per the Prebid documents, the preference is to use mediaTypes.banner.sizes for display ads for 1.0 and later.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information