Update Conversant adapter's support for video playerSize #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pycnvr
changed the title
|
Looking into it now. Thanks. |
|
Thanks @sohlhausen for fixing this issue already. :) I'll close this PR. There are other smaller changes that can be submitted later. |
|
Supplement with these changes:
|
pycnvr
force-pushed
the
video_player_size
branch
from
62c20dc to
1032bd2
Compare
|
@bretg Conflict has been resolved. Thanks. |
harpere
approved these changes
Jan 3, 2019
olafbuitelaar
pushed a commit
to olafbuitelaar/Prebid.js
that referenced
this pull request
Jan 3, 2019
amuraco
pushed a commit
to amuraco/Prebid.js
that referenced
this pull request
Jan 28, 2019
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add support for mediaTypes.video.playerSize, and also support video requests that have no sizes.
contact email of the adapter’s maintainer
pyang@conversantmedia.com
official adapter submission
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information