Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rad 2356 upgrade mocha #3392

Closed
wants to merge 3 commits into from
Closed

Rad 2356 upgrade mocha #3392

wants to merge 3 commits into from

Conversation

deekshithraop
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • [ ✓] Build related changes
  • CI related changes
  • [ NO ] Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Update Mocha to v5, karma to v3, and karma-webpack to v3

Changes in Node version support

  • Since latest versions of those can only be run successfully in latest versions of node, We will be supporting node of version v6 or more.

jsnellbaker
jsnellbaker approved these changes Dec 18, 2018
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker added the needs 2nd review Core module updates require two approvals from the core team label Dec 18, 2018
@stale
Copy link

stale bot commented Jan 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 1, 2019
@jsnellbaker
Copy link
Collaborator

Closing this PR in lieu of #3405 (which includes these changes in addition to some other desired updates).

@jsnellbaker jsnellbaker closed this Jan 2, 2019
@deekshithraop deekshithraop mentioned this pull request Jan 2, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@jaiminpanchal27 jaiminpanchal27 Awaiting requested review from jaiminpanchal27

@matthewlane matthewlane Awaiting requested review from matthewlane

@mkendall07 mkendall07 Awaiting requested review from mkendall07

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
needs 2nd review Core module updates require two approvals from the core team stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deekshithraop @jsnellbaker @jaiminpanchal27