Upgrade packages #3405
Merged
Upgrade packages #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekshithraop
requested review from
mkendall07,
jaiminpanchal27 and
jsnellbaker
jsnellbaker
requested changes
Jan 2, 2019
gulpfile.js
Outdated
| @@ -269,6 +268,25 @@ function coveralls() { // 2nd arg is a dependency: 'test' must be finished | |||
| .pipe(shell('cat build/coverage/lcov.info | node_modules/coveralls/bin/coveralls.js')); | |||
| } | |||
|
|
|||
| gulp.task('watch', function () { | |||
There was a problem hiding this comment.
this gulp task is redundant and can be removed; there is already a watch function declared earlier in the file (see here).
| @@ -34,7 +34,6 @@ function newPluginsArray(browserstack) { | |||
| 'karma-es5-shim', | |||
| 'karma-mocha', | |||
| 'karma-chai', | |||
| 'karma-requirejs', | |||
There was a problem hiding this comment.
If you're removing karma-requirejs plug-in from this file, can it also be removed from the package.json? I don't see it referenced anywhere else in the project.
jsnellbaker
approved these changes
Jan 2, 2019
jsnellbaker
added
needs 2nd review
harpere
added
LGTM
and removed
needs 2nd review
olafbuitelaar
pushed a commit
to olafbuitelaar/Prebid.js
that referenced
this pull request
Jan 3, 2019
* RAD-2356 Upgrade Mocha karma-webpack karma * RAD-2356 update readme to support node v6 or more * Remove webpack output logs while testing * move from gulp-webserver to gulp-connect * remove karma-require and redundant watch task
amuraco
pushed a commit
to amuraco/Prebid.js
that referenced
this pull request
Jan 28, 2019
* RAD-2356 Upgrade Mocha karma-webpack karma * RAD-2356 update readme to support node v6 or more * Remove webpack output logs while testing * move from gulp-webserver to gulp-connect * remove karma-require and redundant watch task
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* RAD-2356 Upgrade Mocha karma-webpack karma * RAD-2356 update readme to support node v6 or more * Remove webpack output logs while testing * move from gulp-webserver to gulp-connect * remove karma-require and redundant watch task
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* RAD-2356 Upgrade Mocha karma-webpack karma * RAD-2356 update readme to support node v6 or more * Remove webpack output logs while testing * move from gulp-webserver to gulp-connect * remove karma-require and redundant watch task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Removing packages with vulnerabilities
on running npm audit package "open" had critical vulnerabilities its being used by by us and by gulp-webserver as its dependency.
Changes in Node version support
Since latest versions of those can only be run successfully in latest versions of node, We will be supporting node of version v6 or more.
Note: this pull req includes the changes in pull req (#3392) which is to update mocha, karma, karma-webpack