New advenue header bidding adapter #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add advenue integration example
Added test for advenue adapter
|
After creating new pull request merge conflict with package-lock steal remains, so original file was uploaded to resolve merge conflict |
jsnellbaker
requested changes
Jan 11, 2019
There was a problem hiding this comment.
Hello @devadvenue
While attempting to test the adapter with the sample test params, I was seeing an error when it was calling your adserver.
POST http://supply.advenuemedia.co.uk/?c=o&m=multi net::ERR_NAME_NOT_RESOLVED
Is this the correct URL? For reference, below is a copy of the associated request payload:
{"secure":0,"deviceWidth":1680,"deviceHeight":1050,"host":"ap.localhost:9999","page":"/integrationExamples/gpt/hello_world.html","placements":[{"placementId":0,"bidId":"23806dd859e866","sizes":[[300,250],[300,600]],"traffic":"banner"}]}
Changed URL, used BidderRequest object
|
update |
|
@devadvenue Thanks for making the updates; LGTM now. |
jsnellbaker
approved these changes
Jan 22, 2019
amuraco
pushed a commit
to amuraco/Prebid.js
that referenced
this pull request
Jan 28, 2019
* Create advenueBidAdapter.js * Create advenueBidAdapter.md * Update pbjs_example_gpt.html Add advenue integration example * Advenue test Added test for advenue adapter * changes made * edit * edit * Syntax error corrected * Remove grunt, changed ajv version to 6.2.2 * Edit * Update package-lock.json * removed response validation * removed unused variables * Removed deprecated method * Package-lock.json deleted * https://github.com/devadvenue/Prebid.js.git deleted * del * Add package-lock.json from main repository * Delete package-lock.json * Only pushing original file resolves merge conflict * Update advenueBidAdapter.js Changed URL, used BidderRequest object * Update advenueBidAdapter_spec.js * Update package-lock.json * Update advenueBidAdapter_spec.js
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* Create advenueBidAdapter.js * Create advenueBidAdapter.md * Update pbjs_example_gpt.html Add advenue integration example * Advenue test Added test for advenue adapter * changes made * edit * edit * Syntax error corrected * Remove grunt, changed ajv version to 6.2.2 * Edit * Update package-lock.json * removed response validation * removed unused variables * Removed deprecated method * Package-lock.json deleted * https://github.com/devadvenue/Prebid.js.git deleted * del * Add package-lock.json from main repository * Delete package-lock.json * Only pushing original file resolves merge conflict * Update advenueBidAdapter.js Changed URL, used BidderRequest object * Update advenueBidAdapter_spec.js * Update package-lock.json * Update advenueBidAdapter_spec.js
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* Create advenueBidAdapter.js * Create advenueBidAdapter.md * Update pbjs_example_gpt.html Add advenue integration example * Advenue test Added test for advenue adapter * changes made * edit * edit * Syntax error corrected * Remove grunt, changed ajv version to 6.2.2 * Edit * Update package-lock.json * removed response validation * removed unused variables * Removed deprecated method * Package-lock.json deleted * https://github.com/devadvenue/Prebid.js.git deleted * del * Add package-lock.json from main repository * Delete package-lock.json * Only pushing original file resolves merge conflict * Update advenueBidAdapter.js Changed URL, used BidderRequest object * Update advenueBidAdapter_spec.js * Update package-lock.json * Update advenueBidAdapter_spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Second pull request to merge without package-lock.json
#3321
Other information
Docs prebid.github.io : prebid/prebid.github.io#1046