Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advenue prebid adapter doc added #1046

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Advenue prebid adapter doc added #1046

merged 2 commits into from
Jan 24, 2019

Conversation

devadvenue
Copy link
Contributor

No description provided.

@devadvenue
Copy link
Contributor Author

Current pull request related to this pull request prebid/Prebid.js#3321

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table needs a 'type' column. Would assume placement is an integer and traffic a string? FWIW - unclear to me what "Type traffic" means in the description.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@devadvenue
Copy link
Contributor Author

Adapter already merged to master

@bretg
Copy link
Contributor

bretg commented Jan 23, 2019

Will be released as part of 1.39 and will merge when that goes live.

@devadvenue
Copy link
Contributor Author

Does it should pass some time after release for docs to be merged, or there is some issues? Because version 1.39 already released but docs are not merged yet

@bretg
Copy link
Contributor

bretg commented Jan 24, 2019

Sorry - it can take us a day or two sometimes to merge the docs after a release has gone out. Doing now.

@bretg bretg merged commit 9ccd69b into prebid:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants