Ensure width and height are integers #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Mar 25, 2019
mkendall07
requested changes
Mar 25, 2019
mkendall07
approved these changes
Mar 26, 2019
mkendall07
added
the
needs 2nd review
jaiminpanchal27
approved these changes
Mar 26, 2019
pycnvr
pushed a commit
to conversant/Prebid.js
that referenced
this pull request
Apr 4, 2019
* Ensure width and height are integers Some bidders (like OpenX) return bid responses with width and height as strings. Let's follow the docs and ensure that they indeed are integers, avoiding some strict comparison surprises. * lint * typo * Update bidderFactory.js * Update bidderFactory.js * Update bidderFactory.js
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* Ensure width and height are integers Some bidders (like OpenX) return bid responses with width and height as strings. Let's follow the docs and ensure that they indeed are integers, avoiding some strict comparison surprises. * lint * typo * Update bidderFactory.js * Update bidderFactory.js * Update bidderFactory.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Some bid responses return width and height as strings. Let's follow the docs and ensure that they indeed are integers, avoiding some strict comparison surprises.