Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure width and height are integers #3674

Merged
merged 6 commits into from
Mar 26, 2019
Merged

Ensure width and height are integers #3674

merged 6 commits into from
Mar 26, 2019

Commits on Mar 25, 2019

  1. Ensure width and height are integers 

    Some bidders (like OpenX) return bid responses with width and height as strings. Let's follow the docs and ensure that they indeed are integers, avoiding some strict comparison surprises.
    @benjaminclot
    benjaminclot committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    d676186 View commit details
    Browse the repository at this point in the history

  2. lint

    @benjaminclot
    benjaminclot committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    6b04aa6 View commit details
    Browse the repository at this point in the history

  3. typo

    @benjaminclot
    benjaminclot committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    e13c5ed View commit details
    Browse the repository at this point in the history

  4. Update bidderFactory.js

    @benjaminclot
    benjaminclot committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    90d7325 View commit details
    Browse the repository at this point in the history

  5. Update bidderFactory.js

    @benjaminclot
    benjaminclot committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    9b6ba0c View commit details
    Browse the repository at this point in the history

  6. Update bidderFactory.js

    @benjaminclot
    benjaminclot committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    757b07e View commit details
    Browse the repository at this point in the history