Updated the bidder code in the test ad unit. #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Also updated certain param names used in the test spec.
…g the CircleCI tests to fail.
…'t always have the crid, so using a sentinel value when we don't have the crid.
- Removed the package-lock file.
# Conflicts: # package-lock.json
…diaTypes.video.playerSize instead of bid.sizes. prebid#3331
- updated the test spec to reflect the above change - removed changes to the package-lock.json file.
# Conflicts: # modules/telariaBidAdapter.js
# Conflicts: # modules/telariaBidAdapter.js Added GDPR support
Merging with master
Merged the fork with the latest master
- Added an example URL.
kd-appier
added a commit
to appier/Prebid.js
that referenced
this pull request
May 30, 2019
* 'master' of https://github.com/appier/Prebid.js: (160 commits) Increment pre version Prebid 2.17.0 Release mgid adapter: add support of currency.adServerCurrency (prebid#3850) We want to remove bidfloor if not set by pb (prebid#3866) aardvark tdid support (prebid#3860) auction key limiter feature (prebid#3825) minor updates to consentManagement tests (prebid#3849) Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854) Adding bidfloor to video imp req (prebid#3863) adding Outstream mediaType to EMX Digital (prebid#3840) Added optional dealId parameter to bid response. (prebid#3858) Update rtbhouseBidAdapter.md (prebid#3857) Updated the bidder code in the test ad unit. (prebid#3844) change in Aardvark adapter to handle additional data (prebid#3821) Refactor bid response - remove unnecessary properties (prebid#3807) Increment pre version Prebid 2.16.0 release fix how native sizes are passed in AppNexus adapter (prebid#3832) updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828) Adding advertiserId to appnexus adapter (prebid#3833) ...
kd-appier
added a commit
to appier/Prebid.js
that referenced
this pull request
May 30, 2019
* master: (160 commits) Increment pre version Prebid 2.17.0 Release mgid adapter: add support of currency.adServerCurrency (prebid#3850) We want to remove bidfloor if not set by pb (prebid#3866) aardvark tdid support (prebid#3860) auction key limiter feature (prebid#3825) minor updates to consentManagement tests (prebid#3849) Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854) Adding bidfloor to video imp req (prebid#3863) adding Outstream mediaType to EMX Digital (prebid#3840) Added optional dealId parameter to bid response. (prebid#3858) Update rtbhouseBidAdapter.md (prebid#3857) Updated the bidder code in the test ad unit. (prebid#3844) change in Aardvark adapter to handle additional data (prebid#3821) Refactor bid response - remove unnecessary properties (prebid#3807) Increment pre version Prebid 2.16.0 release fix how native sizes are passed in AppNexus adapter (prebid#3832) updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828) Adding advertiserId to appnexus adapter (prebid#3833) ...
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* - Updated the test ad unit to use 'telaria' as the bidder code. - Added an example URL. * using the bidder code constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
documentation here https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders -->
Description of change
The test ad unit's bidder code was 'tremor', changed that to 'telaria'. Although 'tremor' still works we would like to move people to using 'telaria'.