Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synacor media bidder updates: filter bad sizes & extra video parameters #3885

Merged
merged 4 commits into from
Jul 11, 2019
Merged

Synacor media bidder updates: filter bad sizes & extra video parameters #3885

merged 4 commits into from
Jul 11, 2019

Conversation

amuraco
Copy link
Contributor

@amuraco amuraco commented Jun 5, 2019

Type of change

  • [ X ] Feature

Description of change

Synacor media bidder updates:
5d085ea 
- Filter out 1x1 & 1x2 adsizes that we don't support
- Added a bunch of openrtb video params
@amuraco amuraco mentioned this pull request Jun 5, 2019
Merged
@mkendall07
Copy link
Member

This pull request introduces 1 alert when merging 5d085ea into 1f9937e - view on LGTM.com

new alerts:

  • 1 for Implicit operand conversion

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

@bretg bretg requested a review from idettman June 10, 2019 14:29
idettman
idettman suggested changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment with a small change request

@mkendall07
Copy link
Member

This pull request introduces 1 alert when merging 1642e4c into cacb6e7 - view on LGTM.com

new alerts:

  • 1 for Implicit operand conversion

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

@amuraco
SynacormediaBidAdapter: Updated setValidVideoParams
cbda9ae 
Updated setValidVideoParams so that the length check works correctly.
@amuraco
Copy link
Contributor Author

amuraco commented Jun 25, 2019

I have made the requested changes, is it possible this can be merged for the next release?

@amuraco
Copy link
Contributor Author

amuraco commented Jul 8, 2019

Bumping this PR, since all requested changes have been made, and no reply or resolution after 2 weeks

idettman
idettman approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit b26e6ad into prebid:master Jul 11, 2019
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Jul 30, 2019
@amuraco @leonardlabat
Synacor media bidder updates: filter bad sizes & extra video paramete…
c3b2e4f 
…rs (prebid#3885)

* Synacor media bidder updates:
- Filter out 1x1 & 1x2 adsizes that we don't support
- Added a bunch of openrtb video params

* SynacormediaBidAdapter: Replace let with const

* SynacormediaBidAdapter: Replace let with const

* SynacormediaBidAdapter: Updated setValidVideoParams

Updated setValidVideoParams so that the length check works correctly.
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
@amuraco
Synacor media bidder updates: filter bad sizes & extra video paramete…
6cacad3 
…rs (prebid#3885)

* Synacor media bidder updates:
- Filter out 1x1 & 1x2 adsizes that we don't support
- Added a bunch of openrtb video params

* SynacormediaBidAdapter: Replace let with const

* SynacormediaBidAdapter: Replace let with const

* SynacormediaBidAdapter: Updated setValidVideoParams

Updated setValidVideoParams so that the length check works correctly.
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
@amuraco
Synacor media bidder updates: filter bad sizes & extra video paramete…
8e2715a 
…rs (prebid#3885)

* Synacor media bidder updates:
- Filter out 1x1 & 1x2 adsizes that we don't support
- Added a bunch of openrtb video params

* SynacormediaBidAdapter: Replace let with const

* SynacormediaBidAdapter: Replace let with const

* SynacormediaBidAdapter: Updated setValidVideoParams

Updated setValidVideoParams so that the length check works correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idettman idettman idettman approved these changes

Assignees

@idettman idettman

Labels
LGTM reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amuraco @mkendall07 @idettman