Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synacormedia bid adapter updates: #1335

Merged
merged 2 commits into from
Jul 25, 2019

Conversation

amuraco
Copy link
Contributor

@amuraco amuraco commented May 30, 2019

  • Added more video parameters
  • Added video example
  • Fixed table so that it renders correctly

Link to PR: prebid/Prebid.js#3885

- Added more video parameters
- Added video example
- Fixed table so that it renders correctly
@amuraco amuraco force-pushed the synacormedia-may-updates branch from e603afa to ea535e8 Compare May 30, 2019 17:48
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add 'scope' as the 2nd column to the video param table

@amuraco
Copy link
Contributor Author

amuraco commented Jun 5, 2019

I have pushed a commit with the requested changes:

  • added scope to the video param table

@rajcspsg
Copy link
Contributor

@bretg Any ETA for this PR to get merged?

@rajcspsg
Copy link
Contributor

Hi Team,
Any updates on this? We have another PR on top this changes.

@bretg bretg merged commit 4963703 into prebid:master Jul 25, 2019
@bretg
Copy link
Contributor

bretg commented Jul 25, 2019

sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants