Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Domain to videoreach.com #4056

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Conversation

VideoReach
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Change domain from videoreach.de to videoreach.com

@jsnellbaker jsnellbaker self-requested a review August 2, 2019 14:02
@jsnellbaker jsnellbaker self-assigned this Aug 2, 2019
@jsnellbaker
Copy link
Collaborator

Hi @VideoReach

Thanks for cleaning everything up since the older PR.

Do you happen to have any test bid params I can use for the adapter? I tried the values in the .md file, but the response that came back returned an empty array.

Given this change is about an updated endpoint - I'd like to ensure that the end-to-end is working as expected. Thanks!

@VideoReach
Copy link
Contributor Author

Hi @jsnellbaker,

Please try "MS8OW" as TagId.

Thanks!

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VideoReach Thanks for providing the test param. LGTM

@jsnellbaker jsnellbaker merged commit b21252c into prebid:master Aug 6, 2019
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 6, 2019
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants