Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Domain to videoreach.com #4056

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Change Domain to videoreach.com #4056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/videoreachBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {registerBidder} from '../src/adapters/bidderFactory';
const utils = require('../src/utils');
const BIDDER_CODE = 'videoreach';
const ENDPOINT_URL = '//a.videoreach.de/hb/';
const ENDPOINT_URL = '//a.videoreach.com/hb/';

export const spec = {
code: BIDDER_CODE,
Expand Down Expand Up @@ -65,7 +65,7 @@ export const spec = {
getUserSyncs: function(syncOptions, responses, gdprConsent) {
const syncs = [];

if (syncOptions.pixelEnabled && responses.length) {
if (syncOptions.pixelEnabled && responses.length && responses[0].body.responses.length) {
const SyncPixels = responses[0].body.responses[0].sync;

let params = '';
Expand Down
2 changes: 1 addition & 1 deletion modules/videoreachBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

**Module Name**: Video Reach Bidder Adapter
**Module Type**: Bidder Adapter
**Maintainer**: hello@videoreach.de
**Maintainer**: hello@videoreach.com

# Description

Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/videoreachBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {expect} from 'chai';
import {spec} from 'modules/videoreachBidAdapter';
import {newBidder} from 'src/adapters/bidderFactory';

const ENDPOINT_URL = '//a.videoreach.de/hb/';
const ENDPOINT_URL = '//a.videoreach.com/hb/';

describe('videoreachBidAdapter', function () {
describe('isBidRequestValid', function () {
Expand Down Expand Up @@ -86,7 +86,7 @@ describe('videoreachBidAdapter', function () {
'cpm': 10.0,
'width': '1',
'height': '1',
'ad': '<script type="text/javascript" async="true" src="//a.videoreach.de/hb/js/?t=f86fb856-15d0-4591-84eb-0830b38e9cf2"></script>',
'ad': '<script type="text/javascript" async="true" src="//a.videoreach.com/hb/js/?t=f86fb856-15d0-4591-84eb-0830b38e9cf2"></script>',
'ttl': 360,
'creativeId': '5cb5dc9375c0e',
'netRevenue': true,
Expand Down