Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifestreet adapter 3.0 #4927

Merged
merged 8 commits into from
Mar 11, 2020
Merged

Lifestreet adapter 3.0 #4927

merged 8 commits into from
Mar 11, 2020

Conversation

probably-kira
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Lifestreet adapter for Prebid 3.0 + CCPA support
We had version for 2.0, but previous version has been deleted from main repo, so I not sure which label is correct. Apologize for this, hope have both is fine.

  • test parameters for validating bids
{
      bidder: 'lifestreet',
      params: {
        slot: 'slot166704',
        adkey: '78c',
        ad_size: '160x600'
      }
}

email of the adapter’s maintainer: hb.tech@lifestreet.com

PR link: prebid/prebid.github.io#1835

Other information

@harpere harpere requested a review from aleksatr March 5, 2020 20:32
@aleksatr
Copy link
Contributor

aleksatr commented Mar 9, 2020

Test coverage is below 80%, please add more unit tests.
You can run gulp test-coverage and gulp view-coverage to check.

@aleksatr
Copy link
Contributor

aleksatr commented Mar 10, 2020 •
edited
Loading

I still see that github reports integrationExamples/gpt/hello_world.html as modified, from what I see this looks like some permission changes on this file? Can you revert all changes on this file?

Other than that, I tested (with your test unit) and req/resp look good, I don't see many changes in comparison to the 2.x version. So if you can fix those small remarks I can approve your changes.

@probably-kira
Copy link
Contributor Author

hi Alexa! all done, it was a pleasure to work with you!

@aleksatr aleksatr merged commit 6113cd9 into prebid:master Mar 11, 2020
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Mar 13, 2020
@redaguermas
Merge branch 'master' of https://github.com/prebid/Prebid.js
36fab76 
* 'master' of https://github.com/prebid/Prebid.js: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Mar 13, 2020
@redaguermas
Merge branch 'master' into NoBid-Version-1.2.4
031ebf1 
* master: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
@probably-kira
Lifestreet adapter 3.0 (prebid#4927)
50fc0dd 
* Added adapter without tests

* Added readme

* Added tests and CCPA support

* Cleaned code, fixed tests

* reverted examples

* Added more tests + CR fixes

* Fixed example in lifestreet readme, reverted integration  example page

* restored permission for page example
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
@probably-kira @rjvelicaria
Lifestreet adapter 3.0 (prebid#4927)
bba0ac0 
* Added adapter without tests

* Added readme

* Added tests and CCPA support

* Cleaned code, fixed tests

* reverted examples

* Added more tests + CR fixes

* Fixed example in lifestreet readme, reverted integration  example page

* restored permission for page example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksatr aleksatr aleksatr left review comments

Assignees

@aleksatr aleksatr

Labels
needs docs needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@probably-kira @aleksatr @harpere