Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eids liveintent ext fix #4944

Merged
merged 37 commits into from
Mar 11, 2020

Conversation

pm-harshad-mane
Copy link
Contributor

Type of change

  • [ X ] Bugfix

Description of change

Liveintent segments should have been in eid.ext not in eid.uids[].ext
added separate functions in config for eid.ext and uid.ext

added separate functions in config for eid.ext and uid.ext
liventent segments should have been in eid.ext not in eid.uids[].ext
@pm-harshad-mane pm-harshad-mane requested a review from idettman March 6, 2020 23:18
@pm-harshad-mane
Copy link
Contributor Author

Hello @idettman ,
I have added an example of the generated eids array in eids.md file
Please let me know if anything else is needed.

@pm-harshad-mane
Copy link
Contributor Author

Hello @idettman
Can we merge this PR?

@jsnellbaker jsnellbaker merged commit efae8f8 into prebid:master Mar 11, 2020
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Mar 13, 2020
* 'master' of https://github.com/prebid/Prebid.js: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Mar 13, 2020
* master: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* fixing liveintent-segments

added separate functions in config for eid.ext and uid.ext
liventent segments should have been in eid.ext not in eid.uids[].ext

* added example of generated eids array

* formating

* commeneted a console log; avoiding lint error

* fixed breaking test-cases
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* fixing liveintent-segments

added separate functions in config for eid.ext and uid.ext
liventent segments should have been in eid.ext not in eid.uids[].ext

* added example of generated eids array

* formating

* commeneted a console log; avoiding lint error

* fixed breaking test-cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants