Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SublimeBidAdapter: Update to version 0.5.1 #4977

Merged
merged 5 commits into from
Apr 21, 2020
Merged

SublimeBidAdapter: Update to version 0.5.1 #4977

merged 5 commits into from
Apr 21, 2020

Conversation

SublimeLeo
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Hello, we made changes on our adapter!
We modified the code style, added some pixels to have more visibility on our adapter behaviour and made debug easier.

  • test parameters for validating bids
{
  bidder: 'sublime',
  params: {
    zoneId: 1
  }
}

@robertrmartinez
Copy link
Collaborator

Hello, taking a look at this now.

We do not allow adapters to fire pixels inside of non registered pixel events, so sending an event for every bidResponse is not allowed.

Adapters should only be sending pixels on the allowed events like,

onTimeout, onBidWon etc

robertrmartinez
robertrmartinez requested changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment and remove any pixel's which are fired outside of the allowed event hooks.

hellsingblack and others added 2 commits April 7, 2020 10:05
@hellsingblack
add prebid version of adapter
f2fbf49
@SublimeLeo
Feature/update sublime adapter (#21)
e14b9e9 
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
robertrmartinez
robertrmartinez requested changes Apr 7, 2020
View reviewed changes
modules/sublimeBidAdapter.js Outdated
const bidResponses = [];
const response = serverResponse.body;

sendEvent('dintres');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pixel fires outside of the pixel listen hooks is not allowed. please remove this.

modules/sublimeBidAdapter.js Outdated

bidResponses.push(bidResponse);
}
sendEvent('bida', true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, please remove

modules/sublimeBidAdapter.js Outdated
sendEvent('bida', true);
bidResponses.push(bidResponse);
} else {
sendEvent('dnobid');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

modules/sublimeBidAdapter.js Outdated
*/
function onTimeout(timeoutData) {
log('Timeout from adapter', timeoutData);
sendEvent('dbidtimeout', true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pixels are allowed onTimeout so you can leave this

SublimeLeo and others added 2 commits April 8, 2020 14:23
@SublimeLeo @fgcloutier @hellsingblack
Remove pixels on non-event and add onBidWon (#22)
d45f02e 
* add prebid version of adapter
* Feature/update sublime adapter (#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
Remove trailing-space
63546eb
@SublimeLeo
Copy link
Contributor Author

Hello @robertrmartinez, sorry for the delay!
We made all the requested changes!

@SublimeLeo
Copy link
Contributor Author

Oops, it seems that we have errors with the CI.
I will fix it asap and I will notify you when it's done!

@SublimeLeo
Copy link
Contributor Author

CI should be fine now!

@robertrmartinez
Copy link
Collaborator

Hi sorry for the delay, have been swamped.

Will get this reviewed and merged tomorrow!

@SublimeLeo
Copy link
Contributor Author

Cool, thank you! Let me know if I missed anything!

@robertrmartinez robertrmartinez self-requested a review April 21, 2020 17:15
robertrmartinez
robertrmartinez approved these changes Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff.

Thanks for this!

@robertrmartinez robertrmartinez merged commit 6311c46 into prebid:master Apr 21, 2020
banesto pushed a commit to banesto/Prebid.js that referenced this pull request Apr 27, 2020
Merge commit '8db2720d60a6533dee52e96f847854ef1c219345'
b94bd8d 
* commit '8db2720d60a6533dee52e96f847854ef1c219345': (249 commits)
  Release 3.17.0
  LunaMedia Adapter (prebid#5110)
  UserId module to export user ids as eids with pbjs.getUserIdsAsEids() (prebid#5108)
  Triplelift: expose tl_souce in bid response (prebid#5139)
  Add warning messages for publishers while native ads send assets containing url without sendId  (prebid#5096)
  use customSlotMatching func for reseting targeting (prebid#5132)
  Teads fix production GDPR error (prebid#5122)
  No bid version 1.2.5 (prebid#5137)
  SublimeBidAdapter src/url.js import fix (prebid#5150)
  Improve Digital adapter: add support for outstream video (prebid#5129)
  Disallowing remote requests from Safari and Firefox due to browsers no longer supporting DigiTrust ID. (prebid#5109)
  PS bid adapter update to copy site object from config (prebid#5083)
  SublimeBidAdapter: Update to version 0.5.1 (prebid#4977)
  LuponMedia Bid Adapter (prebid#5146)
  [BUGFIX] AdagioBidAdapter getDataFromLocalStorage (prebid#5081)
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  ...
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
@SublimeLeo @hellsingblack
@fgcloutier @iggyfisk
SublimeBidAdapter: Update to version 0.5.1 (prebid#4977)
1b622d3 
* add prebid version of adapter

* Feature/update sublime adapter (prebid#21)

* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event

* Remove pixels on non-event and add onBidWon (prebid#22)

* add prebid version of adapter
* Feature/update sublime adapter (prebid#21)
* Update sublimeBidAdapter to 0.5.1
* Add tests for private functions
* Remove window.sublime
* Update pixel name for bid event
* Remove pixels on non-event and add onBidWon
* Incremente version of sublimeBidAdapter
* Renamed pixel for timeout and introduce gvlid
* Remove unnecessary params for sendEvent

Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com>
Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>

* Remove trailing-space

* Fix version in tests

Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com>
Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertrmartinez robertrmartinez robertrmartinez approved these changes

Assignees

@robertrmartinez robertrmartinez

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SublimeLeo @robertrmartinez @mike-chowla @hellsingblack