Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserId module to export user ids as eids with pbjs.getUserIdsAsEids() #5108

Merged
merged 44 commits into from
Apr 22, 2020

Conversation

pm-harshad-mane
Copy link
Contributor

Type of change

  • Feature

Description of change

UserId module to export user ids as eids with pbjs.getUserIdsAsEids()

@jsnellbaker
Copy link
Collaborator

@pm-harshad-mane Do we need a docs PR to list this new function on the Prebid API?

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker added needs 2nd review Core module updates require two approvals from the core team needs docs labels Apr 13, 2020
@jsnellbaker jsnellbaker assigned idettman and unassigned jsnellbaker Apr 13, 2020
modules/userId/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix, then the rest looks good

@pm-harshad-mane
Copy link
Contributor Author

Hello @idettman ,
I will raise a separate documentation PR to prebid.github.io
Can you please merge this?

@pm-harshad-mane
Copy link
Contributor Author

Hello @idettman ,
The CI is passing, documentation is also added.
Could you please merge the PR?

@pm-harshad-mane pm-harshad-mane merged commit ae0ab1d into prebid:master Apr 22, 2020
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
…prebid#5108)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* exposing a new function to export userIds in Eids format

* added test cases for functions that export userIds

* added the missing semicolon :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants