Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatad Bid Adapter #5017

Merged
merged 17 commits into from
Apr 7, 2020
Merged

Add Automatad Bid Adapter #5017

merged 17 commits into from
Apr 7, 2020

Conversation

kanchika-kapoor
Copy link
Contributor

@kanchika-kapoor kanchika-kapoor commented Mar 23, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
    Banner Test Parameters:
var adUnits = [
  {
    code: 'test-div',
    mediaTypes: {
      banner: {
        sizes: [[300,600]]
      }
    },
    bids: [
      {
          bidder: 'automatad',
          params: {
              siteId: 'atd-site-id',
              placementId: 'atd-placement-id'
          }
      }
    ]
  }
];

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer: tech@automatad.com
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

modules/automatadBidAdapter.js Outdated Show resolved Hide resolved
modules/automatadBidAdapter.js Show resolved Hide resolved
modules/automatadBidAdapter.md Show resolved Hide resolved
@msm0504
Copy link
Contributor

msm0504 commented Mar 31, 2020

Docs PR: prebid/prebid.github.io#1876

Copy link
Contributor

@msm0504 msm0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msm0504 msm0504 added the LGTM label Apr 7, 2020
@msm0504 msm0504 merged commit 21d1f53 into prebid:master Apr 7, 2020
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* added automatad bid adapter

* added automatad bid adapter readme

* added automatad bidder adapter unit test

* updated maintainer email id for automatad adapter

* refactored automatadBidAdapter js

* refactored automatadBidAdapter unit test

* refactored automatadBidAdapter unit test

* added usersync code to automatad bid adapter

* Added unit test for onBidWon in automatadBidAdapter_spec

* removed trailing spaces

* removed trailing space

* changes for getUserSync function

* lint error fixes

* updated usersync url

* additional test for onBidWon function added

* added ajax stub in test
@relaido relaido mentioned this pull request Apr 10, 2020
2 tasks
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* added automatad bid adapter

* added automatad bid adapter readme

* added automatad bidder adapter unit test

* updated maintainer email id for automatad adapter

* refactored automatadBidAdapter js

* refactored automatadBidAdapter unit test

* refactored automatadBidAdapter unit test

* added usersync code to automatad bid adapter

* Added unit test for onBidWon in automatadBidAdapter_spec

* removed trailing spaces

* removed trailing space

* changes for getUserSync function

* lint error fixes

* updated usersync url

* additional test for onBidWon function added

* added ajax stub in test
requestId: bid.impid,
cpm: bid.price,
ad: bid.adm,
adDomain: bid.adomain[0],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix to meta.advertiserDomains?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann I have created a pull request for this change #6509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants