Add Relaido Adapter

[relaido]

Type of change

• New bidder adapter

Description of change

New adapter

• test parameters for validating bids

{
  bidder: 'relaido',
  params: {
    placementId: '9900'
  }
}

• contact email of the adapter’s maintainer: video-dev@cg.relaido.co.jp
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/
  Relaido adapter docs prebid.github.io#1917

[Fawke]

@relaido,

Thanks for the PR. I have gone through your code, looks good for the most part. But am facing an issue while I'm trying to test your banner and outstream video ads, taken from the md file.

I'm getting this error:

I did a little bit of digging and thought this maybe because hasUuid() is returning false in isBidRequestValid function. And, this maybe because for the first time, I don't have the value of uuid set in my local storage.

I see you're setting the value of localStorage in this function:

Prebid.js/modules/relaidoBidAdapter.js

Line 216 in 1d0240f

function receiveMessage() {

Is it possible for you to remove the event listener (added in the function receiveMessage) once you've set the key? (We don't want any open handlers)

[relaido]

Hi @Fawke , thanks for the review.
event listener removed.

[Fawke]

@relaido

Thanks for making the change. But, when I'm trying to load your banner ad and video ad following the example you shared in the md file, and plugged those values in the hello_world example, am getting this error.

I think your isBidRequestValid function is returning false because it doesn't find the uuid in localStorage. Can you have a look please?

[relaido]

@Fawke

The first access results in an error because there is no uuid.
Since uuid is registered after UserSync, it succeeds from the second time on.

[Fawke]

@relaido

I put your adapter js file through a debugger and made some observations:

1. In the function setUuid(e), this if condition ((e.data && e.data.relaido_uuid)) is always returning a false. It maybe because the value of e.data is a string.

2. In your getUserSyncs function, you need to have a check in place like this: syncOtions.iframeEnabled. Please take a look at a similar implementation of the appnexus or the rubicon adapter.

3. Also, in the same function getUserSyncs, the parameter serverResponses is coming empty. So, you might better wanna put a check in place, something like: severResponses.length > 0

(serverResponses is empty because no auction is taking place because the function, isBidRequestValid is returning a false)

Also, are there any particular reasons for setting the localStorage value in getUserSyncs function? What if the publisher doesn't allow userSync? What if the pub only allows image sync and not iframe sync?

Since uuid is registered after UserSync, it succeeds from the second time on.

What do you mean second time on? You mean if I refresh the page again? A bit confused, because your isBidRequestValid function is always returning a false, leading to no auction taking place for your bidder. So, how will it succeed the second time on?

[relaido]

@Fawke

this if condition ((e.data && e.data.relaido_uuid)) is always returning a false

Sometimes returns true. e.data can also send objects.

It maybe because the value of e.data is a string.

You're right. Check with isPlainObject.

In your getUserSyncs function, you need to have a check in place like this: syncOtions.iframeEnabled.

Fixed. However, some people have said this.
#5017 (comment)

So, you might better wanna put a check in place, something like: severResponses.length > 0

Fixed.

---

Also, are there any particular reasons for setting the localStorage value in getUserSyncs function?

I want to save uuid in localStorage at the first access.
When the page is updated again, the auction is performed using the uuid stored in localStorage.

What if the publisher doesn't allow userSync?

Unfortunately, no auction is possible.

What if the pub only allows image sync and not iframe sync?

Auction cannot be done here as well.

---

What do you mean second time on?

Is to visit the same page again.
It is the same as refreshing the page.

You mean if I refresh the page again?

The auction will be held because uuid is stored in localStorage.

A bit confused, because your isBidRequestValid function is always returning a false, leading to no auction taking place for your bidder.

Hmm. I can conduct an auction.

So, how will it succeed the second time on?

Do you allow userSync and iframe sync?
Is relaido_uuid stored in localStorage?

[Fawke]

@relaido

Fixed. However, some people have said this.
#5017 (comment)

Unfortunately, that's not right. We still need the check in place. The deprecation was for the publisher facing API, but internally, the adapter is still using iframeEnabled.

Also, I noticed one thing, when sending a banner response, you are returning a vast and overwriting bidResponse.ad with your renderer code.

Is this done to overcome some of prebid's limitations?

Rest of things look okay to me.

[relaido]

@Fawke

The deprecation was for the publisher facing API, but internally, the adapter is still using iframeEnabled.

Thanks. understood.

Is this done to overcome some of prebid's limitations?

Banner could be a safeframe. to overcome that, I pass VASTXML as a parameter.
I referenced this program.
https://github.com/prebid/Prebid.js/blob/master/modules/adgenerationBidAdapter.js#L112-L120

[Fawke]

LGTM

[relaido]

@Fawke

doc also please review.
prebid/prebid.github.io#1917