-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parrableIdSystem: Populate userIdAsEid with Parrable ID and Optout data #5350
Conversation
Add unit coverage for parrableIdSystem getId callback
PBID-14: Support US Privacy Framework
Migrating from legacy _parrable_eid cookie. The new cookie contains ibaOptout and ccpaOptout status fields
…pound cookie value
…ableIdSystem/PBID-11
PBID-11: Integrate new compound cookie
Hi @idettman let me know what I can do to address any doc/design questions here. I see this has a label for needs-docs but am unclear on where I need to write documentation for this change. |
@jimee02, @idettman following up on @icflournoy's post. We could really use some help moving this forward. It's been a month and we have one more PR to enable client time zone based filtering that we cannot submit until this is merged. Thank you 🙏🏻 |
wouldn't you document this here? https://github.com/prebid/prebid.github.io/blob/master/dev-docs/modules/userId.md |
@icflournoy, we currently do not have the capability of passing more than an ID string downstream through our current API, however, we are finalizing a build for an openRTB-supported that will pass the entire eid object through. When I have a PR ready I'll add you as a reviewer. It should be ready by end of August. |
Hi @patmmccann the docs pr is here: prebid/prebid.github.io#2126 this updates only the userId submodule interface. I was looking for a place to document our extended userId info in the ORTB format, the closest place I can find is here: https://github.com/prebid/Prebid.js/blob/master/modules/userId/eids.md @jimee02 that's great to hear, would be happy to take a look when the time comes. As for now, this PR maintains compatibility with your adapter and you will still be receiving only the ID string. |
Hi @jlukas79, please let us know if you have any questions. Would really really appreciate some attention 🙏🏻 |
Change to the PubMatic adapter LGTM |
@jsnellbaker - can you drive this one home? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all looks okay.
Does the reference in the Vidazoo Bid Adapter (https://github.com/prebid/Prebid.js/blob/master/modules/vidazooBidAdapter.js#L26) need to be updated as well to the new syntax?
Please confirm when you have the chance.
@jsnellbaker thanks for the catch. I've updated Vidazoo's bid adapter to consume our new ID structure. Tagging @uditalias who last worked on the adapter for a set of eyes on my change. |
Thanks for the update @icflournoy |
The changes to PulsePoint adapter, LGTM. |
Type of change
Description of change
We add a definition in the userId/eids module that transforms our Parrable ID into the ORTB EIDs format. We supply our iba and ccpa optout statuses as UID extended data.
Implementation changes
userId.parrableId.eid
and we have updated the bid adapters that reference this. Bid adapters that wish to consume our ID in the ORTB format can now do so and receive optout states.parrableId
to match the userId module name.