Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parrableIdSystem: Populate userIdAsEid with Parrable ID and Optout data #5350

Merged
merged 47 commits into from
Aug 4, 2020

Conversation

icflournoy
Copy link
Contributor

Type of change

  • Feature

Description of change

We add a definition in the userId/eids module that transforms our Parrable ID into the ORTB EIDs format. We supply our iba and ccpa optout statuses as UID extended data.

Implementation changes

  • Our parrableIdSystem now returns the entire Parrable ID object from decode(). Our encrypted ID (eid) is now available at userId.parrableId.eid and we have updated the bid adapters that reference this. Bid adapters that wish to consume our ID in the ORTB format can now do so and receive optout states.
  • To be more consistent we've renamed the ID system key to parrableId to match the userId module name.

icflournoy and others added 30 commits April 27, 2020 21:13
Add unit coverage for parrableIdSystem getId callback
PBID-14: Support US Privacy Framework
Migrating from legacy _parrable_eid cookie. The new cookie contains ibaOptout and ccpaOptout status fields
PBID-11: Integrate new compound cookie
@icflournoy
Copy link
Contributor Author

Hi @idettman let me know what I can do to address any doc/design questions here. I see this has a label for needs-docs but am unclear on where I need to write documentation for this change.

@stale stale bot removed the stale label Jul 6, 2020
@justinegreene
Copy link

@jimee02, @idettman following up on @icflournoy's post. We could really use some help moving this forward. It's been a month and we have one more PR to enable client time zone based filtering that we cannot submit until this is merged. Thank you 🙏🏻

@patmmccann
Copy link
Collaborator

@jimee02
Copy link
Contributor

jimee02 commented Jul 13, 2020

@icflournoy, we currently do not have the capability of passing more than an ID string downstream through our current API, however, we are finalizing a build for an openRTB-supported that will pass the entire eid object through. When I have a PR ready I'll add you as a reviewer. It should be ready by end of August.

@icflournoy
Copy link
Contributor Author

Hi @patmmccann the docs pr is here: prebid/prebid.github.io#2126 this updates only the userId submodule interface.

I was looking for a place to document our extended userId info in the ORTB format, the closest place I can find is here: https://github.com/prebid/Prebid.js/blob/master/modules/userId/eids.md

@jimee02 that's great to hear, would be happy to take a look when the time comes. As for now, this PR maintains compatibility with your adapter and you will still be receiving only the ID string.

@bretg bretg removed the needs docs label Jul 16, 2020
@bretg bretg requested a review from jlukas79 July 16, 2020 01:08
@bretg bretg assigned jlukas79 and unassigned idettman Jul 16, 2020
@bretg bretg removed the request for review from idettman July 16, 2020 01:09
@bretg bretg removed the question label Jul 16, 2020
@bretg
Copy link
Collaborator

bretg commented Jul 16, 2020

@idettman is a little backed up, so reassigning over to @jlukas79 . I believe the question has been answered here.

@justinegreene
Copy link

Hi @jlukas79, please let us know if you have any questions. Would really really appreciate some attention 🙏🏻

@mike-chowla
Copy link
Contributor

Change to the PubMatic adapter LGTM

@bretg bretg requested a review from jsnellbaker August 3, 2020 13:21
@bretg bretg assigned jsnellbaker and unassigned jlukas79 Aug 3, 2020
@bretg
Copy link
Collaborator

bretg commented Aug 3, 2020

@jsnellbaker - can you drive this one home?

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all looks okay.

Does the reference in the Vidazoo Bid Adapter (https://github.com/prebid/Prebid.js/blob/master/modules/vidazooBidAdapter.js#L26) need to be updated as well to the new syntax?

Please confirm when you have the chance.

@icflournoy
Copy link
Contributor Author

@jsnellbaker thanks for the catch. I've updated Vidazoo's bid adapter to consume our new ID structure. Tagging @uditalias who last worked on the adapter for a set of eyes on my change.

@uditalias
Copy link
Contributor

Thanks for the update @icflournoy
LGTM

@anand-venkatraman
Copy link
Contributor

The changes to PulsePoint adapter, LGTM.
Thanks

@jsnellbaker jsnellbaker merged commit a770ca7 into prebid:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.