Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New bid adapter for Smaato #5418

Merged
merged 39 commits into from
Jul 22, 2020
Merged

New bid adapter for Smaato #5418

merged 39 commits into from
Jul 22, 2020

Conversation

sbrosinski
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Add a new bidder adapter for Smaato (https://www.smaato.com/)

  • test parameters for validating bids
{
        "bidder": "smaato",
        "params": {
            "publisherId": "1100042525",
            "adspaceId": "130563103"
        }
    }

Other information

  • The adapter requires setup and approval from the Smaato team. The configured endpoint is reachable, but will probably return a no-bid (HTTP 204).
  • This adapter supports configured first party data (value will be copied to the user/site nodes of the outgoing bid requests)
  • Video and user sync support is planned (we're also looking into prebid-server), but not available yet.

@sbrosinski
SmaatoBidAdapter: Initial commit
843583a
@sbrosinski
Add consent management
8f27ce2
@sbrosinski
Add consent test
3051852
@sbrosinski
Smaato: Additional tests
72975e7
@sbrosinski
Smaato: Test endpoint for prebid requests
b4d80db
@sbrosinski
Cleaned up test code
23a2928
@sbrosinski
Validate bid requests
ed41c93
@sbrosinski
Improve banner ad rendering
9f0946d
@sbrosinski
Smaato: Img ad renderer
d733642
@sbrosinski
Cleanup
7d8ec0e
@sbrosinski
Smaato: Handle TTL dynamically
9121829
@sbrosinski
Smaato. Render richmedia ads
119e19d
@sbrosinski
Smaato: Bugfixes
ec39ebc
@sbrosinski
Smaato: More meta data
9145f21
@sbrosinski
Smaato: Consent string handling
249769c
@sbrosinski
Smaato: new endpoint
24609ae
@sbrosinski
Smaato: Fix test
f4f8c31
@sbrosinski
Smaato: Fix test
c932b7d
@sbrosinski
Smaato: Add additional optional params
cfa4dee
@sbrosinski
Smaato: Use first party data for additional context
beca5e1
@sbrosinski
Merge branch 'master' into smaato-adapter
0d3ee12 
* master: (122 commits)
  Vidazoo Adapter: Feature/user-id (prebid#5386)
  Add customParams to yieldlab configuration (prebid#5374)
  added waardex adapter (prebid#5349)
  33Across: CCPA Compliance + Schain support (prebid#5365)
  External ids (prebid#5351)
  PubMatic adds support for bidUserIdAsEids (prebid#5397)
  appnexusBidAdapter - fix video params (prebid#5394)
  Triplelift Adaptor: Use Floors Module (prebid#5329)
  PubMatic bid adapter to support price floors module (prebid#5387)
  Marsmedia & videofy adapters - Add onTimeout & onSetTargeting (prebid#5352)
  Freewheel - Converted the ComponentId property to be 'prebid' in request (prebid#5320)
  UserId SharedId submodule (prebid#5315)
  GumGum: removes deprecated banner sizes default (prebid#5372)
  Apply some updates to Valueimpression bid adapter (prebid#5356)
  Added keywords parameter to TheMediaGrid Bid Adapter (prebid#5353)
  Support for ID5 (prebid#5345)
  PBS Bid Adapter: allow setting site params (prebid#4973)
  Delaying removal of floor data for 3 seconds (prebid#5360)
  Configurable user-sync types support (prebid#5359)
  Add placement_type and position parameters to spotxBidAdapter (prebid#5364)
  ...
@sbrosinski
Smaato: Undoing changes to karma conf
0a1bc9d
@sbrosinski
Smaato: Undo karma konf changes
ecd9c9c
@sbrosinski
Smaato: Fixed test
1f0cbb8
@sbrosinski
Smaato: Update adapter doc
a43760f
@sbrosinski
Smaato: remove unused code
2375c17
@sbrosinski
Smaato: Remove package-lock.json
1119229
@sbrosinski
Smaato: Fix package-lock.json
c70d057
@sbrosinski
Smaato: stricter parsing of first party data
9cc9f80
@sbrosinski
Smaato: increase adapter version
e34e6f0
@mike-chowla mike-chowla requested a review from sumit116 July 2, 2020 23:33
@sbrosinski
Copy link
Contributor Author

sbrosinski commented Jul 6, 2020 •
edited
Loading

@sumit116 / @mike-chowla Please let me know, if I can do anything else to help this get merged.

@sbrosinski
Smaato: Video support
fec868d
@sbrosinski
Smaato: Fix test data
ef00d2f
@sbrosinski
Merge branch 'master' of github.com:prebid/Prebid.js into smaato-adapter
4c2509e 
* 'master' of github.com:prebid/Prebid.js: (39 commits)
  Increment pre version
  Prebid 3.25.0 release
  Add lotame id system (prebid#5388)
  Change endpoint (prebid#5459)
  ozone 2.4.0 adapter updates (prebid#5421)
  Update AppNexus usersync script (prebid#5473)
  Eplanning fix: decode parameters (prebid#5448)
  Teads adapter : Support page referrer and network bandwidth (prebid#5430)
  Merge Valueimpression Bid Adapter to Quantumdex Bid Adapter (prebid#5405)
  Criteo - partially restore adapter before PR prebid#4518 following performance issues (prebid#5376)
  onetagBidAdapter: outstream support (prebid#5435)
  Vidazoo Adapter: Feature/bidder-version (prebid#5384)
  adform and adformOpenRTB bid adapters: Added support for userId modules (prebid#5425)
  proxistore bid adapter: delay request to server by 5 min if there were no bids (prebid#5379)
  Vidazoo Adapter: Feature/subdomain (prebid#5446)
  Inskin Bid adapter small changes (prebid#5373)
  Revert "add AMX adapter (prebid#5383)" (prebid#5455)
  ATS-change logError to logInfo type (prebid#5443)
  ATS-identityLinkId - add additional info logging events (prebid#5442)
  Update padsquad for meta.advertiserDomains (prebid#5439)
  ...
@sbrosinski
Merge branch 'smaato-adapter' into smaato-adapter-video
a3a2fbc 
* smaato-adapter: (40 commits)
  Smaato: Fix test data
  Increment pre version
  Prebid 3.25.0 release
  Add lotame id system (prebid#5388)
  Change endpoint (prebid#5459)
  ozone 2.4.0 adapter updates (prebid#5421)
  Update AppNexus usersync script (prebid#5473)
  Eplanning fix: decode parameters (prebid#5448)
  Teads adapter : Support page referrer and network bandwidth (prebid#5430)
  Merge Valueimpression Bid Adapter to Quantumdex Bid Adapter (prebid#5405)
  Criteo - partially restore adapter before PR prebid#4518 following performance issues (prebid#5376)
  onetagBidAdapter: outstream support (prebid#5435)
  Vidazoo Adapter: Feature/bidder-version (prebid#5384)
  adform and adformOpenRTB bid adapters: Added support for userId modules (prebid#5425)
  proxistore bid adapter: delay request to server by 5 min if there were no bids (prebid#5379)
  Vidazoo Adapter: Feature/subdomain (prebid#5446)
  Inskin Bid adapter small changes (prebid#5373)
  Revert "add AMX adapter (prebid#5383)" (prebid#5455)
  ATS-change logError to logInfo type (prebid#5443)
  ATS-identityLinkId - add additional info logging events (prebid#5442)
  ...
@bretg bretg requested review from msm0504 and removed request for sumit116 July 16, 2020 14:21
@bretg bretg assigned msm0504 and unassigned sumit116 Jul 16, 2020
msm0504
msm0504 suggested changes Jul 21, 2020
View reviewed changes
modules/smaatoBidAdapter.js Show resolved Hide resolved
modules/smaatoBidAdapter.js Outdated Show resolved Hide resolved
modules/smaatoBidAdapter.md Outdated Show resolved Hide resolved
@sbrosinski sbrosinski requested a review from msm0504 July 22, 2020 06:41
@msm0504 msm0504 added LGTM and removed needs review labels Jul 22, 2020
@msm0504 msm0504 merged commit e68cfd1 into prebid:master Jul 22, 2020
@Enigo Enigo deleted the smaato-adapter branch September 29, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msm0504 msm0504 msm0504 approved these changes

Assignees

@msm0504 msm0504

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbrosinski @msm0504 @bretg @sumit116