Update floors module for #5511

[diDNA-matt]

Type of change

• Other

Description

• When no floor data is available after the floors module is invoked, records 'noData' in the bidRequest[ ].floorData.location field
• Adds the field floorProvider, to the top level of the floor object. The value is a string and defaults to an empty string if none is provided.

Updates made for #5511

[robertrmartinez]

Hey @diDNA-matt Thanks a bunch for getting to this! Nice to have another developer working on the module.

Couple things that may have been a misunderstanding.

I'll let @bszekely1 confirm since he wrote the issue.

[bszekely1]

Hey @diDNA-matt Thanks a bunch for getting to this! Nice to have another developer working on the module.

Couple things that may have been a misunderstanding.

I'll let @bszekely1 confirm since he wrote the issue.

I addressed the point in the main issue ticket, but to briefly reiterate that the Floors Module will always default to 0 when not supplied by the publisher or a floors provider. This makes it impossible for the skipRate to be undefined. The Floors Module will define when available.

[robertrmartinez]

Awesome stuff thank you!

If you could just fix the .md file we are good.

Will get another prebid org member to review!

[robertrmartinez]

@Fawke

I have approved this pending the .md update.

Please give it a look when you can!

[Fawke]

The PR looks good to me. Do we need to update the docs on Prebid.org since we're adding a new key, floorProvider?

[robertrmartinez]

@bszekely1

There should be some docs updated regarding floorProvider and how it is meant to be used.

Just a pass through from the floors module to the analytics adapters so they can filter out floors which do not come from their own data (wether that be in the analytics module itself, or simply passing along the provider name and their server side pipeline can do the filtering)

[bszekely1]

PR for documentation: prebid/prebid.github.io#2169

Brief note, I added additional functionality and flexibility of the floorProvider parameter to be at the top level of the floors object and within the data object to allow floor provider to self-declare.