LunaMedia HB Bid Adapter: add video context & outstream handling

[lunamedia]

Type of change

• Feature

Description of change

Allow publishers to set context:outstream for video demand to get vastXml response.

[patmmccann]

Please see also #6466

[mmoschovas]

Prebid nests the playerSize array that is defined in the ad unit, meaning that [640, 480] is converted to [[640,480]]. So currently, you will only be passing an array through placement.wPlayer and placement.hPlayer is undefined and therefore dropped. I believe you are trying to pass the individual number values of the playerSize through their respective properties, so you will need to look into the second array in order to do so.

placement.wPlayer = mediaType[VIDEO].playerSize[0][0];
placement.hPlayer = mediaType[VIDEO].playerSize[0][1];

[ChrisHuie]

@lunamedia following up on the above reviewer comment for this pr and also issue #6466

Let me know if I can help on this pr.

[lunamedia]

Chris, Thanks for the note. We will look into this and get back to you!

…

On Wed, Apr 14, 2021 at 9:16 AM Chris Huie ***@***.***> wrote: @lunamedia <https://github.com/lunamedia> following up on the above reviewer comment for this pr and also issue #6466 <#6466> Let me know if I can help on this pr. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6458 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARRFG3JGOMLZNBTLY65DM53TIWIUPANCNFSM4ZU7SS6A> .

[patmmccann]

please note that the old lunamedia adapter is in violation of #6512 and won't be ported to prebid 5 currently. Is this lunamedia hb your new adapter and the old one is deprecated?

[lunamedia]

Hi Patrick, We are fine to deprecate it but we are transitioning a few clients over. Can we keep it up for a little bit and confirm once all clients are off it?

…

On Fri, Jun 4, 2021 at 1:12 PM Patrick McCann ***@***.***> wrote: please note that the old lunamedia adapter is in violation of #6512 <#6512> and won't be ported to prebid 5 currently. Is this lunamedia hb your new adapter and the old one is deprecated? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6458 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARRFG3MKPWYTXMDHMOVORO3TRECQBANCNFSM4ZU7SS6A> .

[patmmccann]

Please also fix #6650 for luna hb on this PR.

Advise your clients to transition to Luna HB on or before their upgrade to Prebid 5. Your adapter won't stop working unless your clients upgrade to Prebid 5

[ChrisHuie]

@lunamedia This pr has been outstanding for a while. Is this still being worked on? We are cleaning out old prs so if I don't hear back on this by Thanksgiving will close and you can reopen when needed.

[lunamedia]

Hi Chris, Adding @daniel Cohen ***@***.***> and @Mary Drachova ***@***.***> who manage the operation at Luna Media. We will get back to you as soon as possible Best, John

…

On Mon, Nov 15, 2021 at 2:23 PM Chris Huie ***@***.***> wrote: @lunamedia <https://github.com/lunamedia> This pr has been outstanding for a while. Is this still being worked on? We are cleaning out old prs so if I don't hear back on this by Thanksgiving will close and you can reopen when needed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6458 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARRFG3PDOPWRWECHJCHNXBTUMD3T3ANCNFSM4ZU7SS6A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.