-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapters must support advertiserDomains #6466
Comments
This was referenced Mar 24, 2021
Please see #6495 for an example of how to make this fix |
9 tasks
Thanks @kanchika-automatad! I removed your adapter from the list above |
9 tasks
2 tasks
1 task
9 tasks
7 tasks
This was referenced Apr 27, 2021
This was referenced May 7, 2021
K-JBoon
added a commit
to bluebillywig/Prebid.js
that referenced
this issue
Jun 3, 2021
9 tasks
ChrisHuie
added a commit
that referenced
this issue
Jun 3, 2021
* add Blue Billywig adapter * Blue Billywig Adapter - update according to review feedback * Blue Billywig Adapter - update to try and pass CircleCI * Remove the last for .. of in bluebillywigBidAdapter.js, hopefully... * Update bluebillywigBidAdapter test parameters to match renderer to rendererCode rename * Blue Billywig - Also pass through site config with OpenRTB request * add Blue Billywig adapter * Blue Billywig Adapter - update according to review feedback * Blue Billywig Adapter - update to try and pass CircleCI * Remove the last for .. of in bluebillywigBidAdapter.js, hopefully... * Code quality update, always hit user syncs, improved video params * Add support for meta.advertiserDomains to BB Adapter, addresses issue #6466 * kick off circleci tests Co-authored-by: Klaas-Jan Boon <klaas-janboon@ip-172-16-224-85.eu-west-1.compute.internal> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
bretg
changed the title
Adapter supports adomain but not meta.advertiserDomains
Adapters must supports advertiserDomains
Jun 11, 2021
bretg
changed the title
Adapters must supports advertiserDomains
Adapters must support advertiserDomains
Jun 11, 2021
6 tasks
This was referenced Jun 18, 2021
Closed
Closed
1 task
9 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type of issue
Some bidders explicitly support adomain in their adapter code but don't set meta.advertiserDomains . Others support it in their Prebid.js/test/spec/modules but not in their adapter js. This issue lists both types.
Specifically, this adapter has support for adomain but not meta.advertiserDomains:
https://github.com/patmmccann/Prebid.js/blob/master/modules/ozoneBidAdapter.js @afsheenb @AskRupert-DM
These support it in their test but not explicitly in their adapter.
~/Prebid.js/modules$ grep dvertiserDomains *BidAdapter.js | awk -F ':' '{print $1}' | awk -F '.' '{print $1}' > ~/adomains.txt
~/Prebid.js/test/spec/modules$ grep -i adomain *BidAdapter_spec.js | awk -F ':' '{print $1}' > ~/adomain_test.txt
grep -v ~/adomain_test.txt -f ~/adomains.txt | sort | uniq
adponeBidAdapter_spec.js @seergiioo6
advangelistsBidAdapter_spec.js @trchandraprakash
bidphysicsBidAdapter_spec.js @bidphysics
bizzclickBidAdapter_spec.js @BizzClick
cedatoBidAdapter_spec.js @alexkh13
cleanmedianetBidAdapter_spec.js @sa1omon
cosmosBidAdapter_spec.js @dev-cosmos
ebdrBidAdapter_spec.js @jlzhangdev
gamoshiBidAdapter_spec.js @sa1omon
lemmaBidAdapter_spec.js @lemmadev
lkqdBidAdapter_spec.js @david-carver
lunamediaBidAdapter_spec.js @trchandraprakash
marsmediaBidAdapter_spec.js @vladi-mmg
newborntownWebBidAdapter_spec.js @z-sunshine
pxyzBidAdapter_spec.js @monofonik
resultsmediaBidAdapter_spec.js @vladi-mmg
theAdxBidAdapter_spec.js @mustafakemal16
timBidAdapter_spec.js @borisjaskerovich
unicornBidAdapter_spec.js @ctylim
yieldliftBidAdapter_spec.js @yieldlift
The text was updated successfully, but these errors were encountered: