Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ozone Bid Adapter: Ozone v2.6.0 adapter updates (resubmission) #6987

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Ozone Bid Adapter: Ozone v2.6.0 adapter updates (resubmission) #6987

merged 2 commits into from
Jun 9, 2021

Conversation

afsheenb
Copy link
Contributor

@afsheenb afsheenb commented Jun 9, 2021

Type of change
• Bugfix
• Feature

Description of changes

• Added CCPA/US Privacy Support
• Added support for additional QueryParams
• Added support for Price Floors Module per #6465
• Added support for First Party Data Enrichment Module
• Bug Fix for ID5 per #6324
• Bug Fix for ensuring adId is unique to ozone by appending an -oz- prefix in the adId to solve feedback per #6381
• Bug Fix to support meta.advertiserDomains per #6466

(Resubmitting this due to earlier issues with CircleCI integration tests with PR #6946)

engineering@ozoneproject.com

@patmmccann
Copy link
Collaborator

Hi @afsheenb

This block of output in circleci is the concern

Chrome 89.0.4389 (Windows 10.0.0): Executed 1 of 8339 SUCCESS (0.01 secs / 0.005 secs)
Chrome 79.0.3945 (Windows 10.0.0): Executed 1 of 8339 SUCCESS (0.035 secs / 0.006 secs)
Edge 17.17134.0 (Windows 10.0.0): Executed 1 of 8339 SUCCESS (0.043 secs / 0.006 secs)
Edge 18.18363.0 (Windows 10.0.0): Executed 1 of 8339 SUCCESS (0.028 secs / 0.007 secs)
IE 11.0.0 (Windows 10.0.0): Executed 1 of 8339 SUCCESS (0.049 secs / 0.011 secs)
Firefox 73.0.0 (Windows 10.0.0): Executed 1 of 8339 SUCCESS (0.023 secs / 0.007 secs)
Firefox 72.0.0 (Windows 10.0.0): Executed 1 of 8339 SUCCESS (0.021 secs / 0.005 secs)
Safari 13.1.2 (Mac OS X 10.15.6): Executed 1 of 8339 SUCCESS (0.012 secs / 0.002 secs)
Safari 12.1.2 (Mac OS X 10.14.6): Executed 1 of 8339 SUCCESS (0.01 secs / 0.002 secs)
TOTAL: 9 SUCCESS

Typically many tests are executed, not just 9

@AskRupert-DM
Copy link
Contributor

@patmmccann - its due a .only statement in my tests - updating in a few mins - bare with me (just rechecking it locally)

@ChrisHuie ChrisHuie self-requested a review June 9, 2021 16:51
@ChrisHuie ChrisHuie self-assigned this Jun 9, 2021
@ChrisHuie ChrisHuie merged commit bafb0cc into prebid:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants