Prevent SpringServe TypeError #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `find` returns `undefined`, attempting to access properties on `requestBids` raises a `TypeError`.
protonate
reviewed
Sep 30, 2016
| var requestBids = $$PREBID_GLOBAL$$._bidsRequested.find(bidSet => bidSet.bidderCode === 'springserve').bids | ||
| .filter(bid => bid.params && bid.params.impId === +responseBid.impid); | ||
| var requestBids = $$PREBID_GLOBAL$$._bidsRequested.find(bidSet => bidSet.bidderCode === 'springserve'); | ||
| if (requestBids) { |
There was a problem hiding this comment.
should check if bids.length > 0
protonate
approved these changes
Sep 30, 2016
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* Prevent SpringServe TypeError If `find` returns `undefined`, attempting to access properties on `requestBids` raises a `TypeError`. * Check bids length
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* Prevent SpringServe TypeError If `find` returns `undefined`, attempting to access properties on `requestBids` raises a `TypeError`. * Check bids length
marian-r
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Nov 2, 2016
…ebid-0.13.1 to release/1.4.0 * commit 'd174ef271e55e7f26210f50caac52c0a036bc9a1': CHANGELOG. 0.13.1 release add an --https flag to run local dev server over https (prebid#670) test ie variant of url parse pathname (prebid#669) Prevent SpringServe TypeError (prebid#663) XDomainRequest does not support `readyState` and was not executing the callback. (prebid#668) Prevent Sovrn TypeError (prebid#664) Prevent TripleLift TypeError (prebid#662) fixed bug with using non standard "standard" keys and sendAllBids (prebid#665) Initial value 0 for adder. (prebid#656) Prevent bidmanager TypeError (prebid#661) Prevent Pubmatic TypeError (prebid#666) Size mapping functionality (prebid#651) Added '320x80': 59, '320x320': 72, '320x160': 73 to RUBICON_SIZE_MAP (prebid#649) Add defy alias + increment version. (prebid#650) Add additional sizes to rubicon size mapping (prebid#646)
marian-r
added a commit
to aol/Prebid.js
that referenced
this pull request
Nov 2, 2016
…4.0 to master * commit '5e7eec42d84ec5de47a28ba493a9357b595761d3': CHANGELOG. New adapter. 0.13.1 release add an --https flag to run local dev server over https (prebid#670) test ie variant of url parse pathname (prebid#669) Prevent SpringServe TypeError (prebid#663) XDomainRequest does not support `readyState` and was not executing the callback. (prebid#668) Prevent Sovrn TypeError (prebid#664) Prevent TripleLift TypeError (prebid#662) fixed bug with using non standard "standard" keys and sendAllBids (prebid#665) Initial value 0 for adder. (prebid#656) Prevent bidmanager TypeError (prebid#661) Prevent Pubmatic TypeError (prebid#666) Size mapping functionality (prebid#651) Added '320x80': 59, '320x320': 72, '320x160': 73 to RUBICON_SIZE_MAP (prebid#649) Add defy alias + increment version. (prebid#650) Add additional sizes to rubicon size mapping (prebid#646)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
If
findreturnsundefined, attempting to access properties onrequestBidsraises aTypeError. This occasionally causes uncaught exceptions when using Karma in debug mode (gulp serve --watch, check in dev tools console). Fixing this may help stabilize the unit test failures observed in #642.Other information
@prebid/springserve, please review this change or feel free to submit a PR that handles this exception.