Adding AdButler Adapter

[dharton]

Type of change

• New bidder adapter

Description of change

This change will add the AdButler bidder adapter.

• test parameters for validating bids

{
  bidder: 'adbutler',
  params: {
    accountID : '167283', //required
    zoneID : '210093', //required       
    minCPM: '1.00', //optional
    maxCPM: '5.00', //optional
    keyword : 'green' //optional
  }
}

• contact email of the adapter’s maintainer:
  dan@sparklit.com
• official adapter submission

[matthewlane]

@dharton Thank you for the new adapter PR. I left a few notes for your review below. Also when testing this adapter on a page with the provided test params, I'm running into the error Uncaught SyntaxError: missing ) after argument list originating from here, wanted to check if you see that too

[matthewlane]

Please use .stub here rather than .spy. A spy on adLoader.loadScript can potentially result in script errors and cause other tests to fail. See this commit for context

[matthewlane]

This occasionally causes Uncaught TypeError: Cannot read property 'sizes' of undefined when running unit tests. Please check that callbackData[callbackId] exists before access the sizes property. See #662, #663, and #664 for PRs where we caught similar TypeErrors

[matthewlane]

Accessing placementCode when callbackData[callbackID] is undefined could also cause TypeErrors. These particularly pop up when Karma is left in debug mode, which you can check with gulp serve --watch and then opening the developer console

[dharton]

@matthewlane Thanks for the feedback! I've committed changes to clear up those issues.

I provided you with invalid test parameters by mistake, and that's why you were seeing the SyntaxError on the adapter test. I've updated the parameters, and that should be fixed up now, as well.

Please let me know if there is anything else you need from me.

[matthewlane]

@dharton Changes look good and I'm able to validate bids with the update parameters. Left a few more comments for your review, when those are addressed I'll review again as soon as possible and we should be good to merge

[matthewlane]

This can cause another TypeError which occasionally fails unit tests. Checking callbackData[callbackID] before accessing bidId will fix this. Something like bidObj = callbackData[callbackID] ? utils.getBidRequest(callbackData[callbackID].bidId) : null; will work as a one-liner but feel free to do the check however you prefer

[matthewlane]

Pass bidObj as second param to createBid

[matthewlane]

Pass bidObj as second param to createBid

[matthewlane]

createBid can take bidObj as a second parameter here to set the response ID to the request ID. See #509 for background info

[dharton]

@matthewlane I've updated the code to reflect your comments.

Thanks for the heads up about passing the bid request object into createBid().

[matthewlane]

@dharton Thanks, merged. Can you also please create a PR to add the AdButler bidder params to the docs repo? If you create a file in the bidders directory (can copy an existing file and modify the params for AdButler) that'll get added to the Prebid bidders page. Thanks