Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules enforcement: Video OpenRTB fields cannot only be read from bidder parameters #6807

Closed
wants to merge 43 commits into from

Conversation

patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented May 21, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Solution to #6512

@lgtm-com
Copy link

lgtm-com bot commented May 21, 2021

This pull request fixes 2 alerts when merging 5546e1f into 22ad110 - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Client-side cross-site scripting

@lgtm-com
Copy link

lgtm-com bot commented May 21, 2021

This pull request fixes 2 alerts when merging a16fc25 into 6957925 - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional
  • 1 for Client-side cross-site scripting

@patmmccann
Copy link
Collaborator Author

patmmccann commented May 24, 2021

Note fixed for gridnm in #6817 , will resolve conflicts in favor of their change when it gets merged to master
thanks to @TheMediaGrid

@ym-dlabuzov
Copy link
Contributor

We made #6873 to fix this for Yieldmo Bid Adapter

@patmmccann
Copy link
Collaborator Author

Thanks @ym-dlabuzov !! Happy holiday

@patmmccann
Copy link
Collaborator Author

closing and re-opening with the reduced list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants