Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneVideo Bid Adapter: adomain & mediaTypes.video Support (SAPR-16874) #6925

Merged
merged 27 commits into from
Jun 3, 2021

Conversation

adam-browning
Copy link
Contributor

Type of change

  • [ x] Other

Description of change

Hi @patmmccann
In alignment with #6807 the oneVideoBidAdapter now listens to bid.mediaTypes.video params first. bid.params.video are used as overrides or in cases where bid.mediaTypes.video params are missing.
This update includes:

  1. First look at bid.mediaTypes.video params
  2. bid.params.video - as overrides (backward compatible)
  3. Validation granular error messages that will display when pbjs_debug=true.
  4. skip validations for e2etest mode.
  • test parameters for validating bids
    This test will only work if you pass bid.params.site.page = "https:verizonmedia.com"
    And make the request using VPN location US west coast.
const adUnits = [{
                code: 'video1',
                mediaTypes: {
                    video: {
                        context: 'outstream',
                        playerSize: [300, 250],
                        mimes: ['video/mp4','application/javascript'],
                    }
                },
                bids: [
                    {
                        bidder: 'oneVideo',
                        params: {
                            pubId: 'HBExchange'
                        }
                    }
                ]
            }];

Other information

Hi @DeepthiNeeladri & @kprasadpvv,
Prebid V.5 is supposed to go live on June 9th.
I have created this PR to mitigate removal of the adapter specifically for this version.
Would you be able to review please?
Main changes are in validations and param settings.

Thanks in advance!
Adam

@patmmccann
Copy link
Collaborator

Thanks so much! Does this cover #6650 as well?

Copy link
Contributor

@DeepthiNeeladri DeepthiNeeladri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!! we are keeping the linearity param the same rest all we are validating

@adam-browning
Copy link
Contributor Author

Hi @patmmccann,
I have added meta.advertiserDomains support that covers #6650 as well.
Thanks in advance,
Adam

@patmmccann patmmccann changed the title oneVideo Bid Adapter: mediaTypes.video Support (SAPR-16874) oneVideo Bid Adapter: adomain & mediaTypes.video Support (SAPR-16874) Jun 3, 2021
@patmmccann patmmccann merged commit 25a495c into prebid:master Jun 3, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants