Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimera RTD Module: initial release #6962

Merged
merged 5 commits into from
Jun 7, 2021
Merged

Optimera RTD Module: initial release #6962

merged 5 commits into from
Jun 7, 2021

Conversation

mcallari
Copy link
Contributor

@mcallari mcallari commented Jun 7, 2021 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Adding Optimera RTD provider submodule
Adding tests
Adding docs
Adding integration example
Adding as child module of RTD for easier builds

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

@mcallari mcallari mentioned this pull request Jun 7, 2021
Merged
patmmccann
patmmccann requested changes Jun 7, 2021
View reviewed changes
modules/optimeraRtdProvider.md Show resolved Hide resolved
modules/optimeraRtdProvider.js Show resolved Hide resolved
@patmmccann
Copy link
Collaborator

Please note circleci did not run, usually means you are following your own project in circleci

@mcallari
Copy link
Contributor Author

mcallari commented Jun 7, 2021

Please note circleci did not run, usually means you are following your own project in circleci

I unfollowed the project.

@patmmccann
Copy link
Collaborator

Please repull master to solve test issues

@mcallari mcallari force-pushed the optimeraRtdProvider branch from 105c2c6 to 6499aac Compare June 7, 2021 21:38
@patmmccann patmmccann changed the title Add the Optimera RTD Provider. Optimera RTD Module: initial release Jun 7, 2021
@patmmccann
Copy link
Collaborator

@ChrisHuie do you see why these parable tests are failing by any chance? They are fine on master

@patmmccann
Copy link
Collaborator

@mcallari this appears good to merge assuming these parrable tests are unrelated, asked chris to make sure

@mcallari
Copy link
Contributor Author

mcallari commented Jun 7, 2021

sked chris to make sure

Thanks, @patmmccann. The tests all pass locally, but if I need to add the before and after hooks to resolve the tests, happy to do so depending on what Chris says.

@patmmccann patmmccann merged commit 3ea9b0a into prebid:master Jun 7, 2021
@patmmccann
Copy link
Collaborator

Looks like that was the solution, thanks for your contribution!

@mcallari
Copy link
Contributor Author

mcallari commented Jun 7, 2021

sked chris to make sure

Thanks, @patmmccann. The tests all pass locally, but if I need to add the before and after hooks to resolve the tests, happy to do so depending on what Chris says.

Update: I added those hooks and the tests passed. Thanks for all your help!

@patmmccann patmmccann mentioned this pull request Jun 10, 2021
Merged
10 tasks
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
@mcallari @agrandes-tappx
Optimera RTD Module: initial release (prebid#6962)
6e2c830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcallari @patmmccann