Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the OptimeraRTD provider Doc. #3015

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

mcallari
Copy link
Contributor

@mcallari mcallari commented Jun 7, 2021

This is for the Optimera Real Time Data Module.

The main PR is here: PR #6962

2) in your browser, navigate to:

```
http://localhost:9999integrationExamples/gpt/optimeraRtdProvider_example.html
Copy link
Collaborator

@patmmccann patmmccann Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a typo here after the port number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @patmmccann. I updated it.

`gulp build --modules=optimeraRtdProvider`...
```

2) Use `setConfig` to instruct Prebid.js to initilize the optimera module, as specified below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: s/b initialize

description: Optimera Optimization Targeting
page_type: module
module_type: rtd
module_code : optimeraRTD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module_code needs to match the file name. So this should be optimeraRtdProvider

@bretg
Copy link
Contributor

bretg commented Jun 11, 2021

@mcallari - since PBJS 5.0 is launched, we need you to make these changes to get you on the download page. Or alternately you can give be write permission to your fork and I'll make the changes.

@mcallari mcallari force-pushed the optimeraRtdProvider branch from 370fa43 to 59ac626 Compare June 14, 2021 15:01
@mcallari
Copy link
Contributor Author

@mcallari - since PBJS 5.0 is launched, we need you to make these changes to get you on the download page. Or alternately you can give be write permission to your fork and I'll make the changes.

Hi @bretg, I just pushed the changes.

@jeanstemp jeanstemp merged commit 278060a into prebid:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants