Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realvu Analytics Adapter: improve flagging of 'display:none' containers #7182

Merged
merged 10 commits into from
Jul 21, 2021

Conversation

tchibirev
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Improve flagging containers when style.display='none'

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title Improve flagging of 'display:none' containers Realvu Analytics Adapter: improve flagging of 'display:none' containers Jul 20, 2021
@ChrisHuie ChrisHuie requested a review from Rothalack July 20, 2021 11:31
@Rothalack
Copy link
Collaborator

This looks good to go and all my testing worked.

@Rothalack Rothalack merged commit 1381f34 into prebid:master Jul 21, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
…rs (prebid#7182)

* Remove _ps in _f=conf request

* Replace "

* realvuAnalyticsAdapter_spec updated

* Update realvuAnalyticsAdapter.js

* Update realvuAnalyticsAdapter.js

Improve value returned by addUnitById()

* Update realvuAnalyticsAdapter.js

improve flagging of 'display:none' containers

* Update realvuAnalyticsAdapter.js

Co-authored-by: Igor Tchibirev <igor@realvu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants