Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realvu Analytics Adapter: improve flagging of 'display:none' containers #7182

Merged
merged 10 commits into from
Jul 21, 2021
Merged

Realvu Analytics Adapter: improve flagging of 'display:none' containers #7182

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2690014
Remove _ps in _f=conf request
Jul 15, 2019
7d8a155
Replace "
Jul 15, 2019
54780e5
realvuAnalyticsAdapter_spec updated
Jul 23, 2019
d00dad7
Merge branch 'prebid:master' into master
tchibirev Jun 12, 2021
69b05f9
Update realvuAnalyticsAdapter.js
tchibirev Jun 12, 2021
ccd9ac2
Merge branch 'prebid:master' into master
tchibirev Jun 23, 2021
9a0e26e
Update realvuAnalyticsAdapter.js
tchibirev Jun 23, 2021
4a24708
Merge branch 'prebid:master' into master
tchibirev Jul 14, 2021
d775ab3
Update realvuAnalyticsAdapter.js
tchibirev Jul 15, 2021
dada1f3
Update realvuAnalyticsAdapter.js
tchibirev Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 40 additions & 22 deletions modules/realvuAnalyticsAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,28 +306,46 @@ export let lib = {
if (!restored) {
a.target = z.questA(a.div);
let target = (a.target !== null) ? a.target : a.div;
a.box.w = Math.max(target.offsetWidth, a.w);
a.box.h = Math.max(target.offsetHeight, a.h);
let q = z.findPosG(target);
let pad = {};
pad.t = z.padd(target, 'Top');
pad.l = z.padd(target, 'Left');
pad.r = z.padd(target, 'Right');
pad.b = z.padd(target, 'Bottom');
let ax = q.x + pad.l;
let ay = q.y + pad.t;
a.box.x = ax;
a.box.y = ay;
if (a.box.w > a.w && a.box.w > 1) {
ax += (a.box.w - a.w - pad.l - pad.r) / 2;
}
if (a.box.h > a.h && a.box.h > 1) {
ay += (a.box.h - a.h - pad.t - pad.b) / 2;
}
if ((ax > 0 && ay > 0) && (a.x != ax || a.y != ay)) {
a.x = ax;
a.y = ay;
z.writePos(a);
if (window.getComputedStyle(target).display == 'none') {
let targSibl = target.previousElementSibling; // for 'none' containers on mobile define y as previous sibling y+h
if (targSibl) {
let q = z.findPosG(targSibl);
a.x = q.x;
a.y = q.y + targSibl.offsetHeight;
} else {
target = target.parentNode;
let q = z.findPosG(target);
a.x = q.x;
a.y = q.y;
}
a.box.x = a.x;
a.box.y = a.y;
a.box.w = a.w;
a.box.h = a.h;
} else {
a.box.w = Math.max(target.offsetWidth, a.w);
a.box.h = Math.max(target.offsetHeight, a.h);
let q = z.findPosG(target);
let pad = {};
pad.t = z.padd(target, 'Top');
pad.l = z.padd(target, 'Left');
pad.r = z.padd(target, 'Right');
pad.b = z.padd(target, 'Bottom');
let ax = q.x + pad.l;
let ay = q.y + pad.t;
a.box.x = ax;
a.box.y = ay;
if (a.box.w > a.w && a.box.w > 1) {
ax += (a.box.w - a.w - pad.l - pad.r) / 2;
}
if (a.box.h > a.h && a.box.h > 1) {
ay += (a.box.h - a.h - pad.t - pad.b) / 2;
}
if ((ax > 0 && ay > 0) && (a.x != ax || a.y != ay)) {
a.x = ax;
a.y = ay;
z.writePos(a);
}
}
}
let vtr = ((a.box.w * a.box.h) < 242500) ? 49 : 29; // treashfold more then 49% and more then 29% for "oversized"
Expand Down