YieldOne Bid Adapter: add Flux Wrapper support. #7555
Conversation
|
@kyoya-takei can you please change back the specific imports for the utils instead of importing the whole file with |
…he whole module (prebid#7502)"
This solved. |
|
Hi, team (@umakajan ) How long will the review take? Thank you. |
|
@haruka-yamashita2 I added another possible reviewer to help get this reviewed. |
|
Hi, team (@ChrisHuie ) Excuse me for being busy, but is it likely that reviews will still take place? Thank you. |
modules/yieldoneBidAdapter.js
Outdated
| } | ||
|
|
||
| const result = playerSize || DEFAULT_VIDEO_SIZE; | ||
| return result; |
There was a problem hiding this comment.
We can simply return playerSize || DEFAULT_VIDEO_SIZE here
| /** | ||
| * @param {Object} bidRequest - | ||
| * @param {boolean} [enabledOldFormat = true] - default: `true`. | ||
| * @return {{w: number, h: number}} - |
modules/yieldoneBidAdapter.js
Outdated
| } | ||
|
|
||
| const result = parseSizesInput(sizes).join(','); | ||
| return result; |
There was a problem hiding this comment.
Following the other comments, might be cleaner to simply return parseSizesInput(sizes).join(',');
|
sorry for the delay, this looks good. @haruka-yamashita2 will wait to merge until you confirm you'd like to attend to the minor feedback from @umakajan |
|
@umakajan @ncolletti Thank you. |
|
@haruka-yamashita2 these are minor code changes, so you're welcome to change them later by letting us know or simply make the changes and add a commit to this PR. We can merge the PR after. |
|
@umakajan Thank you. |
* YieldOne Bid Adapter: add Flux Wrapper support. * YieldOne Bid Adapter: fix "import utils functions as needed and not the whole module (prebid#7502)" * YieldOne Bid Adapter: fix minor feedback. Co-authored-by: kenichi-ichijo <kenichi-ichijo@dac.co.jp>
Type of change
Description of change
Supported multi format ads
Supported [1, 1] size for video type
contact email of the adapter’s maintainer
official adapter submission
A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/