-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YieldOne Bid Adapter: Update doc. #3335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a prebid change going along with this? If yes, please link the PR in a comment here 🤗
| Name | Scope | Description | Example | Type | | ||
|-----------------|----------|----------------------------------|--------------|-------------------| | ||
| `placementId` | required | The placement ID | `"36891"` | `string` | | ||
| `playerSize` | optional | Video Resolution Size<br/>(This field is mandatory if mediaTypes.video.playerSize is [1, 1]) | `[640, 360]` | `array of number` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any further information on the player available, e.g.
- what does 1x1 trigger? A responsive player?
- is the actual playerSize setting obeyed or is the player still changing its size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because video can only be set to one size, it is not always possible to set a common size when various bidder are connected. In such cases, there are cases where 1x1 is used. However, in our server, sending a request with 1x1 will result in a bad request due to a size error, so it is necessary to adjust the playerSize. Currently, there is no plan to deal with size errors on the server side, so we use playerSize to deal with it.
A prebid change along with this is below : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed that the PBJS yieldone adapter already supports these params
YieldOne Bid Adapter: Update doc.