Prebid Core: Resolved warning in console during allowedAlternateBidderCodes winner #8554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed net revenue to True
Syncing with Upstream
patmmccann
approved these changes
Jun 14, 2022
patmmccann
added
the
needs 2nd review
|
Looks good to me, Mike or Harshad, are you able to provide second review? |
renebaudisch
pushed a commit
to renebaudisch/Prebid.js
that referenced
this pull request
Jun 28, 2022
…rCodes winner (prebid#8554) * Changed net revenue to True * send adapterCode as bidder when available Co-authored-by: Azhar <azhar@L1119.local>
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
…rCodes winner (prebid#8554) * Changed net revenue to True * send adapterCode as bidder when available Co-authored-by: Azhar <azhar@L1119.local>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
During our testing of
allowedAlternateBidderCodesfunctionality, we found a warning being displayed in the console when the bidder fromallowedAlternateBidderCodeslist would win. Attached is the screenshot below.