Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid Core: Resolved warning in console during allowedAlternateBidderCodes winner #8554

Merged
merged 21 commits into from
Jun 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/bidViewability.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export let impressionViewableHandler = (globalModuleConfig, slot, event) => {
// if config is enabled AND VURL array is present then execute each pixel
fireViewabilityPixels(globalModuleConfig, respectiveBid);
// trigger respective bidder's onBidViewable handler
adapterManager.callBidViewableBidder(respectiveBid.bidder, respectiveBid);
adapterManager.callBidViewableBidder(respectiveBid.adapterCode || respectiveBid.bidder, respectiveBid);
// emit the BID_VIEWABLE event with bid details, this event can be consumed by bidders and analytics pixels
events.emit(CONSTANTS.EVENTS.BID_VIEWABLE, respectiveBid);
}
Expand Down
4 changes: 2 additions & 2 deletions src/auction.js
Original file line number Diff line number Diff line change
Expand Up @@ -324,11 +324,11 @@ export function newAuction({adUnits, adUnitCodes, callback, cbTimeout, labels, a

function addWinningBid(winningBid) {
_winningBids = _winningBids.concat(winningBid);
adapterManager.callBidWonBidder(winningBid.bidder, winningBid, adUnits);
adapterManager.callBidWonBidder(winningBid.adapterCode || winningBid.bidder, winningBid, adUnits);
}

function setBidTargeting(bid) {
adapterManager.callSetTargetingBidder(bid.bidder, bid);
adapterManager.callSetTargetingBidder(bid.adapterCode || bid.bidder, bid);
}

return {
Expand Down