PBS Bid Adapter: add context to emitted seatnonbid event #9804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
changed the title
| auctionId, | ||
| response, | ||
| requestedBidders, | ||
| adapterMetrics |
There was a problem hiding this comment.
maybe we can just pass everything in context instead of destrucutring cals and then passing em all?
events.emit(CONSTANTS.EVENTS.SEAT_NON_BID, { ...context } );Also, we probably do not want these objects to be modified in the downstream event handlers.
I cannot remember if the event handler makes copies before executing the handlers or not? Or if it is up to the emitter to only pass copies.
|
ok now I am remembering that some of these in Sorry, but I think we should just pass through as is @spotxslagle |
ChrisHuie
changed the title
dgirardi
approved these changes
May 16, 2023
robertrmartinez
approved these changes
May 18, 2023
mscottnelson
added a commit
to 33Across/Prebid.js
that referenced
this pull request
Jun 2, 2023
* 33across_analytics_adapter: Adman Adapter: remove useless parameter (prebid#9967) Rise Bid Adapter: support sua and plcmt params. (prebid#9996) clean.io RTD Module: Use loadExternalScript function instead of insertElement() method to insert the Clean.io script. (prebid#9991) Bump socket.io-parser from 4.2.1 to 4.2.3 (prebid#9992) AdHash Bid Adapter: changes to support preroll videos (prebid#9870) RTB House Bid Adapter: docs update - FLEDGE support (prebid#9986) Core: fix in ortb -> legacy native asset conversion (prebid#9923) Adnuntius Bid Adaptor: Handling deals better (prebid#9943) FreeWheel SSP Adapter: add support for video.plcmt (prebid#9978) PubMatic Bid Adapter: Added support for video.plcmt (prebid#9979) Criteo Bid Adapter: add support for video.plcmt (prebid#9975) add SSP Copper6 alias adapter (prebid#9972) Criteo bid adapter: Add video outstream renderer (prebid#9955) PBS Bid Adapter: add context to emitted seatnonbid event (prebid#9804) GumGum Bid Adapter : Id5 integration suppress link type for ttd (prebid#9924) Increment version to 7.51.0-pre Prebid 7.50.0 release Docs Integration Examples : add Events UI page for Video Module (prebid#9934) LiveIntent UserId module: add support for distributorId configuration parameter (prebid#9963) Underdog Media Bid Adapter: Update ttl & referer information (prebid#9826) eps_aliasing - adding in aliases for epsilon (formerly conversant) for bidder and analytics (prebid#9961) Add mobile client hint 33x adapter (prebid#9958) confiant Rtd Provider : add message type check (prebid#9950) Criteo Bid Adapter: add support for imp.rwdd (prebid#9964) Yahoo SSP adapter support for extra site publisher info. (prebid#9921) RubiconBidAdapter: sync parseSize algorithm for isBidRequestValid and ortb conversion (prebid#9957) Ticket: IDG-829
musikele
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Aug 28, 2023
* Add context to emitted seatnonbid event * Add unit test coverage * Sanitize and emit context * Remove sanitize step for emitted data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adds additional information to the emitted seatnonbid event.
Other information
@robertrmartinez