Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yahoo SSP adapter support for extra site publisher info. #9921

Merged

Conversation

radubarbos
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • [ x] Other

Description of change

The purpose of this change is to allow extra first party OpenRTB data to be sent to our back-ends, in particular the openRTB.site.publisher.ext information.

Other information

@radubarbos
Copy link
Contributor Author

@jlukas79 could you please check this PR at your earliest convenience as we need this deployed ASAP. thank you.

@patmmccann patmmccann self-requested a review May 9, 2023 12:12
@patmmccann patmmccann self-assigned this May 9, 2023
@patmmccann
Copy link
Collaborator

patmmccann commented May 9, 2023

Hi!

Thank you for your submission.

A couple housekeeping notes: a warning was added to your adapter documentation to reflect the discussion on #9345 . We're hoping you can update us with your plans.

Do you want the AOL adapter to be part of prebid 8 or not?
See #9592

Why cherry pick site.publisher.ext instead of just taking the whole site object?

@radubarbos
Copy link
Contributor Author

Hi,

For the consent warning you mentioned we don't have a concrete plan atm with exact dates.
For the the AOL adapter I'll try to find out and update #9592

We pick the specific site properties as we want to provide the smallest change possible for our back-ends. This can be an item to discuss, but we need a plan for it (confirmation from back-end services, proper testing and revenue monitoring). It should be straightforward as it's just OpenRTB standard but for this change we do what we've always done, we allow specific properties.

@radubarbos
Copy link
Contributor Author

I noticed that the needs docs label was added. Is some documentation we have to update? The change allows more openRTB data to be sent to the back-end.

@patmmccann
Copy link
Collaborator

Yes please document which open rtb properties you send to your backend, for example, site.publisher.ext but nothing else in site.publisher, other than that, this is ready to merge

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just awaiting the docs pull

@radubarbos
Copy link
Contributor Author

I updated the first party site info section with the list of keys that are filtered by the yahoossp bidder. To me was the best place to describe this. Let me know if it is accepted.

@radubarbos
Copy link
Contributor Author

@patmmccann are you ok with the latest changes?

@patmmccann patmmccann merged commit 92daa81 into prebid:master May 17, 2023
mscottnelson added a commit to 33Across/Prebid.js that referenced this pull request Jun 2, 2023
* 33across_analytics_adapter:
  Adman Adapter: remove useless parameter (prebid#9967)
  Rise Bid Adapter: support sua and plcmt params. (prebid#9996)
  clean.io RTD Module: Use loadExternalScript function instead of insertElement() method to insert the Clean.io script. (prebid#9991)
  Bump socket.io-parser from 4.2.1 to 4.2.3 (prebid#9992)
  AdHash Bid Adapter: changes to support preroll videos (prebid#9870)
  RTB House Bid Adapter: docs update - FLEDGE support (prebid#9986)
  Core: fix  in ortb -> legacy native asset conversion (prebid#9923)
  Adnuntius Bid Adaptor: Handling deals better (prebid#9943)
  FreeWheel SSP Adapter: add support for video.plcmt (prebid#9978)
  PubMatic Bid Adapter: Added support for video.plcmt (prebid#9979)
  Criteo Bid Adapter: add support for video.plcmt (prebid#9975)
  add SSP Copper6 alias adapter (prebid#9972)
  Criteo bid adapter: Add video outstream renderer (prebid#9955)
  PBS Bid Adapter: add context to emitted seatnonbid event (prebid#9804)
  GumGum Bid Adapter : Id5 integration suppress link type for ttd (prebid#9924)
  Increment version to 7.51.0-pre
  Prebid 7.50.0 release
  Docs Integration Examples : add Events UI page for Video Module  (prebid#9934)
  LiveIntent UserId module: add support for distributorId configuration parameter (prebid#9963)
  Underdog Media Bid Adapter: Update ttl & referer information (prebid#9826)
  eps_aliasing - adding in aliases for epsilon (formerly conversant) for bidder and analytics (prebid#9961)
  Add mobile client hint 33x adapter (prebid#9958)
  confiant Rtd Provider : add message type check (prebid#9950)
  Criteo Bid Adapter: add support for imp.rwdd (prebid#9964)
  Yahoo SSP adapter support for extra site publisher info. (prebid#9921)
  RubiconBidAdapter: sync parseSize algorithm for isBidRequestValid and ortb conversion (prebid#9957)

Ticket: IDG-829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants