Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][AdManager][Banner] An ad is not rendered properly. Part 2 #113

Merged
merged 6 commits into from
Jun 24, 2019

Conversation

yoalex5
Copy link
Collaborator

@yoalex5 yoalex5 commented Jun 19, 2019

GitHub issue

  1. Multisize support was added
  2. UnitTests were added
  3. UI test was added

The Utility function looks like:

dfpAdView.setAdListener(new AdListener() {
    @Override
    public void onAdLoaded() {
        super.onAdLoaded();

        Util.findPrebidCreativeSize(dfpAdView, new Util.CreativeSizeCompletionHandler() {
            @Override
            public void onSize(final Util.CreativeSize size) {
                if (size != null) {
                    dfpAdView.setAdSizes(new AdSize(size.getWidth(), size.getHeight()));
                }
            }
        });
    }
});

Please note that Util.CreativeSize size will be always null if API < 19 (Currently the min API for the project is 16)

@yoalex5
Copy link
Collaborator Author

yoalex5 commented Jun 19, 2019

The utility method makes the same as iOS pr

Please do not merge to the master branch
Tomorrow I am going to make full tests on a real device with different AdMAnagerSDK versions.

@yoalex5
Copy link
Collaborator Author

yoalex5 commented Jun 20, 2019

I have updated the PR. Also I have tested it on the real device with different AdManagerSDK versions.

@yoalex5
Copy link
Collaborator Author

yoalex5 commented Jun 21, 2019

@ppuviarasu, Could you please review this PR ?

@bszekely1 bszekely1 requested a review from ppuviarasu June 24, 2019 17:44
@ppuviarasu ppuviarasu requested review from anwzhang and removed request for ppuviarasu June 24, 2019 17:45
@ppuviarasu ppuviarasu merged commit 57e040b into prebid:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants